This makes a quick pass through our tests;
Discard output/err
----------------------------------------------
Many tests were testing for error-conditions, but didn't discard output.
This produced a lot of noise when running the tests, and made it hard
to discover if there were actual failures, or if the output was expected.
For example:
=== RUN TestConfigCreateErrors
Error: "create" requires exactly 2 arguments.
See 'create --help'.
Usage: create [OPTIONS] CONFIG file|- [flags]
Create a config from a file or STDIN
Error: "create" requires exactly 2 arguments.
See 'create --help'.
Usage: create [OPTIONS] CONFIG file|- [flags]
Create a config from a file or STDIN
Error: error creating config
--- PASS: TestConfigCreateErrors (0.00s)
And after discarding output:
=== RUN TestConfigCreateErrors
--- PASS: TestConfigCreateErrors (0.00s)
Use sub-tests where possible
----------------------------------------------
Some tests were already set-up to use test-tables, and even had a usable
name (or in some cases "error" to check for). Change them to actual sub-
tests. Same test as above, but now with sub-tests and output discarded:
=== RUN TestConfigCreateErrors
=== RUN TestConfigCreateErrors/requires_exactly_2_arguments
=== RUN TestConfigCreateErrors/requires_exactly_2_arguments#01
=== RUN TestConfigCreateErrors/error_creating_config
--- PASS: TestConfigCreateErrors (0.00s)
--- PASS: TestConfigCreateErrors/requires_exactly_2_arguments (0.00s)
--- PASS: TestConfigCreateErrors/requires_exactly_2_arguments#01 (0.00s)
--- PASS: TestConfigCreateErrors/error_creating_config (0.00s)
PASS
It's not perfect in all cases (in the above, there's duplicate "expected"
errors, but Go conveniently adds "#01" for the duplicate). There's probably
also various tests I missed that could still use the same changes applied;
we can improve these in follow-ups.
Set cmd.Args to prevent test-failures
----------------------------------------------
When running tests from my IDE, it compiles the tests before running,
then executes the compiled binary to run the tests. Cobra doesn't like
that, because in that situation `os.Args` is taken as argument for the
command that's executed. The command that's tested now sees the test-
flags as arguments (`-test.v -test.run ..`), which causes various tests
to fail ("Command XYZ does not accept arguments").
# compile the tests:
go test -c -o foo.test
# execute the test:
./foo.test -test.v -test.run TestFoo
=== RUN TestFoo
Error: "foo" accepts no arguments.
The Cobra maintainers ran into the same situation, and for their own
use have added a special case to ignore `os.Args` in these cases;
https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1078-L1083
args := c.args
// Workaround FAIL with "go test -v" or "cobra.test -test.v", see #155
if c.args == nil && filepath.Base(os.Args[0]) != "cobra.test" {
args = os.Args[1:]
}
Unfortunately, that exception is too specific (only checks for `cobra.test`),
so doesn't automatically fix the issue for other test-binaries. They did
provide a `cmd.SetArgs()` utility for this purpose
https://github.com/spf13/cobra/blob/v1.8.1/command.go#L276-L280
// SetArgs sets arguments for the command. It is set to os.Args[1:] by default, if desired, can be overridden
// particularly useful when testing.
func (c *Command) SetArgs(a []string) {
c.args = a
}
And the fix is to explicitly set the command's args to an empty slice to
prevent Cobra from falling back to using `os.Args[1:]` as arguments.
cmd := newSomeThingCommand()
cmd.SetArgs([]string{})
Some tests already take this issue into account, and I updated some tests
for this, but there's likely many other ones that can use the same treatment.
Perhaps the Cobra maintainers would accept a contribution to make their
condition less specific and to look for binaries ending with a `.test`
suffix (which is what compiled binaries usually are named as).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
154 lines
3.8 KiB
Go
154 lines
3.8 KiB
Go
package plugin
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/docker/cli/internal/test"
|
|
"github.com/docker/docker/api/types"
|
|
"gotest.tools/v3/assert"
|
|
"gotest.tools/v3/golden"
|
|
)
|
|
|
|
var pluginFoo = &types.Plugin{
|
|
ID: "id-foo",
|
|
Name: "name-foo",
|
|
Config: types.PluginConfig{
|
|
Description: "plugin foo description",
|
|
DockerVersion: "17.12.1-ce",
|
|
Documentation: "plugin foo documentation",
|
|
Entrypoint: []string{"/foo"},
|
|
Interface: types.PluginConfigInterface{
|
|
Socket: "pluginfoo.sock",
|
|
},
|
|
Linux: types.PluginConfigLinux{
|
|
Capabilities: []string{"CAP_SYS_ADMIN"},
|
|
},
|
|
WorkDir: "workdir-foo",
|
|
Rootfs: &types.PluginConfigRootfs{
|
|
DiffIds: []string{"sha256:8603eedd4ea52cebb2f22b45405a3dc8f78ba3e31bf18f27b4547a9ff930e0bd"},
|
|
Type: "layers",
|
|
},
|
|
},
|
|
}
|
|
|
|
func TestInspectErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
description string
|
|
args []string
|
|
flags map[string]string
|
|
expectedError string
|
|
inspectFunc func(name string) (*types.Plugin, []byte, error)
|
|
}{
|
|
{
|
|
description: "too few arguments",
|
|
args: []string{},
|
|
expectedError: "requires at least 1 argument",
|
|
},
|
|
{
|
|
description: "error inspecting plugin",
|
|
args: []string{"foo"},
|
|
expectedError: "error inspecting plugin",
|
|
inspectFunc: func(name string) (*types.Plugin, []byte, error) {
|
|
return nil, nil, errors.New("error inspecting plugin")
|
|
},
|
|
},
|
|
{
|
|
description: "invalid format",
|
|
args: []string{"foo"},
|
|
flags: map[string]string{
|
|
"format": "{{invalid format}}",
|
|
},
|
|
expectedError: "template parsing error",
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
tc := tc
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{pluginInspectFunc: tc.inspectFunc})
|
|
cmd := newInspectCommand(cli)
|
|
cmd.SetArgs(tc.args)
|
|
for key, value := range tc.flags {
|
|
cmd.Flags().Set(key, value)
|
|
}
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetErr(io.Discard)
|
|
assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestInspect(t *testing.T) {
|
|
testCases := []struct {
|
|
description string
|
|
args []string
|
|
flags map[string]string
|
|
golden string
|
|
inspectFunc func(name string) (*types.Plugin, []byte, error)
|
|
}{
|
|
{
|
|
description: "inspect single plugin with format",
|
|
args: []string{"foo"},
|
|
flags: map[string]string{
|
|
"format": "{{ .Name }}",
|
|
},
|
|
golden: "plugin-inspect-single-with-format.golden",
|
|
inspectFunc: func(name string) (*types.Plugin, []byte, error) {
|
|
return &types.Plugin{
|
|
ID: "id-foo",
|
|
Name: "name-foo",
|
|
}, []byte{}, nil
|
|
},
|
|
},
|
|
{
|
|
description: "inspect single plugin without format",
|
|
args: []string{"foo"},
|
|
golden: "plugin-inspect-single-without-format.golden",
|
|
inspectFunc: func(name string) (*types.Plugin, []byte, error) {
|
|
return pluginFoo, nil, nil
|
|
},
|
|
},
|
|
{
|
|
description: "inspect multiple plugins with format",
|
|
args: []string{"foo", "bar"},
|
|
flags: map[string]string{
|
|
"format": "{{ .Name }}",
|
|
},
|
|
golden: "plugin-inspect-multiple-with-format.golden",
|
|
inspectFunc: func(name string) (*types.Plugin, []byte, error) {
|
|
switch name {
|
|
case "foo":
|
|
return &types.Plugin{
|
|
ID: "id-foo",
|
|
Name: "name-foo",
|
|
}, []byte{}, nil
|
|
case "bar":
|
|
return &types.Plugin{
|
|
ID: "id-bar",
|
|
Name: "name-bar",
|
|
}, []byte{}, nil
|
|
default:
|
|
return nil, nil, fmt.Errorf("unexpected plugin name: %s", name)
|
|
}
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
tc := tc
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{pluginInspectFunc: tc.inspectFunc})
|
|
cmd := newInspectCommand(cli)
|
|
cmd.SetArgs(tc.args)
|
|
for key, value := range tc.flags {
|
|
cmd.Flags().Set(key, value)
|
|
}
|
|
assert.NilError(t, cmd.Execute())
|
|
golden.Assert(t, cli.OutBuffer().String(), tc.golden)
|
|
})
|
|
}
|
|
}
|