2ef34ed7cf
Instead of calling syscall.Close() on the fds in sendUnix() we call Close() on the *os.File in Send(). Otherwise the fd will be closed, but the *os.File will continue to live, and when it is finalized the fd will be closed (which by then may be reused and can be anything). This also adds a note to Send() the the file is closed. Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson) Upstream-commit: 1fb0bf1b3b7ba2f5188bb58ef8d6991173e6b0f2 Component: engine
pkg/ is a collection of utility packages used by the Docker project without being specific to its internals.
Utility packages are kept separate from the docker core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Docker organization, to facilitate re-use by other projects. However that is not the priority.
The directory pkg is named after the same directory in the camlistore project. Since Brad is a core
Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!
Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!