Files
docker-cli/cli/command/container
Alano Terblanche 30a73ff19c fix: ctx should cancel image pull on run
This patch fixes the context cancellation
behaviour for the `runContainer` function,
specifically the `createContainer` function
introduced in this commit 991b1303da.

It delays stripping the `cancel` from the context
passed into the `runContainer` function so that
the `createContainer` function can be cancelled
gracefully by a SIGTERM/SIGINT.

This is especially true when the requested image
does not exist and `docker run` needs to `pull`
the image before creating the container.

Although this patch does gracefully cancel
the `runContainer` function it does not address
the root cause. Some functions in the call path
are not context aware, such as `pullImage`.

Future work would still be necessary to ensure
a consistent behaviour in the CLI.

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
2024-11-28 09:53:04 +01:00
..
2017-10-26 12:21:02 -04:00
2023-12-12 22:30:16 +01:00
2023-12-12 22:30:16 +01:00
2024-07-04 01:35:12 +02:00
2023-12-12 22:30:16 +01:00
2024-11-12 12:38:18 +01:00
2023-12-12 22:30:16 +01:00
2024-07-04 15:22:18 +02:00
2023-12-12 22:30:16 +01:00
2023-12-12 22:30:16 +01:00
2023-05-05 18:23:03 +02:00
2021-05-24 19:37:53 +01:00
2024-07-04 15:22:18 +02:00
2023-12-12 22:30:16 +01:00