30f1b651e2
Use strongly typed errors to set HTTP status codes. Error interfaces are defined in the api/errors package and errors returned from controllers are checked against these interfaces. Errors can be wraeped in a pkg/errors.Causer, as long as somewhere in the line of causes one of the interfaces is implemented. The special error interfaces take precedence over Causer, meaning if both Causer and one of the new error interfaces are implemented, the Causer is not traversed. Signed-off-by: Brian Goff <cpuguy83@gmail.com> Upstream-commit: ebcb7d6b406fe50ea9a237c73004d75884184c33 Component: engine
96 lines
3.3 KiB
Go
96 lines
3.3 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/integration-cli/request"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func (s *DockerSuite) TestAPICreateWithInvalidHealthcheckParams(c *check.C) {
|
|
// test invalid Interval in Healthcheck: less than 0s
|
|
name := "test1"
|
|
config := map[string]interface{}{
|
|
"Image": "busybox",
|
|
"Healthcheck": map[string]interface{}{
|
|
"Interval": -10 * time.Millisecond,
|
|
"Timeout": time.Second,
|
|
"Retries": int(1000),
|
|
},
|
|
}
|
|
|
|
status, body, err := request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusBadRequest)
|
|
expected := fmt.Sprintf("Interval in Healthcheck cannot be less than %s", container.MinimumDuration)
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
// test invalid Interval in Healthcheck: larger than 0s but less than 1ms
|
|
name = "test2"
|
|
config = map[string]interface{}{
|
|
"Image": "busybox",
|
|
"Healthcheck": map[string]interface{}{
|
|
"Interval": 500 * time.Microsecond,
|
|
"Timeout": time.Second,
|
|
"Retries": int(1000),
|
|
},
|
|
}
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusBadRequest)
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
// test invalid Timeout in Healthcheck: less than 1ms
|
|
name = "test3"
|
|
config = map[string]interface{}{
|
|
"Image": "busybox",
|
|
"Healthcheck": map[string]interface{}{
|
|
"Interval": time.Second,
|
|
"Timeout": -100 * time.Millisecond,
|
|
"Retries": int(1000),
|
|
},
|
|
}
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusBadRequest)
|
|
expected = fmt.Sprintf("Timeout in Healthcheck cannot be less than %s", container.MinimumDuration)
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
// test invalid Retries in Healthcheck: less than 0
|
|
name = "test4"
|
|
config = map[string]interface{}{
|
|
"Image": "busybox",
|
|
"Healthcheck": map[string]interface{}{
|
|
"Interval": time.Second,
|
|
"Timeout": time.Second,
|
|
"Retries": int(-10),
|
|
},
|
|
}
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusBadRequest)
|
|
expected = "Retries in Healthcheck cannot be negative"
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
// test invalid StartPeriod in Healthcheck: not 0 and less than 1ms
|
|
name = "test3"
|
|
config = map[string]interface{}{
|
|
"Image": "busybox",
|
|
"Healthcheck": map[string]interface{}{
|
|
"Interval": time.Second,
|
|
"Timeout": time.Second,
|
|
"Retries": int(1000),
|
|
"StartPeriod": 100 * time.Microsecond,
|
|
},
|
|
}
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusBadRequest)
|
|
expected = fmt.Sprintf("StartPeriod in Healthcheck cannot be less than %s", container.MinimumDuration)
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
}
|