6f5b54ba77
During error cases, we dont cleanup correctly. This commit takes care of removing the plugin, if there are errors after the pull passed. It also shuts down the plugin, if there are errors after the plugin in the enable path. Signed-off-by: Anusha Ragunathan <anusha@docker.com> Upstream-commit: 1144f8f1d4b1fd2bbf1f41bf5dad8d929d0dc06e Component: engine
72 lines
1.8 KiB
Go
72 lines
1.8 KiB
Go
package client
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/url"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
// PluginInstall installs a plugin
|
|
func (cli *Client) PluginInstall(ctx context.Context, name string, options types.PluginInstallOptions) (err error) {
|
|
// FIXME(vdemeester) name is a ref, we might want to parse/validate it here.
|
|
query := url.Values{}
|
|
query.Set("name", name)
|
|
resp, err := cli.tryPluginPull(ctx, query, options.RegistryAuth)
|
|
if resp.statusCode == http.StatusUnauthorized && options.PrivilegeFunc != nil {
|
|
newAuthHeader, privilegeErr := options.PrivilegeFunc()
|
|
if privilegeErr != nil {
|
|
ensureReaderClosed(resp)
|
|
return privilegeErr
|
|
}
|
|
resp, err = cli.tryPluginPull(ctx, query, newAuthHeader)
|
|
}
|
|
if err != nil {
|
|
ensureReaderClosed(resp)
|
|
return err
|
|
}
|
|
|
|
defer func() {
|
|
if err != nil {
|
|
delResp, _ := cli.delete(ctx, "/plugins/"+name, nil, nil)
|
|
ensureReaderClosed(delResp)
|
|
}
|
|
}()
|
|
|
|
var privileges types.PluginPrivileges
|
|
if err := json.NewDecoder(resp.body).Decode(&privileges); err != nil {
|
|
ensureReaderClosed(resp)
|
|
return err
|
|
}
|
|
ensureReaderClosed(resp)
|
|
|
|
if !options.AcceptAllPermissions && options.AcceptPermissionsFunc != nil && len(privileges) > 0 {
|
|
accept, err := options.AcceptPermissionsFunc(privileges)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !accept {
|
|
return pluginPermissionDenied{name}
|
|
}
|
|
}
|
|
|
|
if len(options.Args) > 0 {
|
|
if err := cli.PluginSet(ctx, name, options.Args); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if options.Disabled {
|
|
return nil
|
|
}
|
|
|
|
return cli.PluginEnable(ctx, name)
|
|
}
|
|
|
|
func (cli *Client) tryPluginPull(ctx context.Context, query url.Values, registryAuth string) (serverResponse, error) {
|
|
headers := map[string][]string{"X-Registry-Auth": {registryAuth}}
|
|
return cli.post(ctx, "/plugins/pull", query, nil, headers)
|
|
}
|