Please the linters in preparation of updating golangci-lint;
- remove dot-imports
- add some checks for unhandled errors
- replace some fixed-value variables for consts
cli/command/image/build/context.go:238:17: G107: Potential HTTP request made with variable url (gosec)
if resp, err = http.Get(url); err != nil {
^
cli/command/idresolver/idresolver_test.go:7:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/registry_test.go:7:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/cli/command" // Prevents a circular import with "github.com/docker/cli/internal/test"
^
cli/command/task/print_test.go:11:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/swarm/update_test.go:10:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/swarm/unlock_key_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/swarm/join_token_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/node/list_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/node/promote_test.go:8:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/node/demote_test.go:8:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package functions
^
cli/command/node/ps_test.go:11:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/node/update_test.go:8:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/node/inspect_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package functions
^
cli/command/secret/ls_test.go:11:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/secret/inspect_test.go:11:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/volume/inspect_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/volume/list_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/config/inspect_test.go:11:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/config/ls_test.go:11:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/network/list_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders"
^
cli/command/container/list_test.go:10:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/service/list_test.go:12:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders"
^
cli/command/service/client_test.go:6:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/stack/list_test.go:8:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/stack/services_test.go:9:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
cli/command/stack/ps_test.go:10:2: dot-imports: should not use dot imports (revive)
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
176 lines
5.6 KiB
Go
176 lines
5.6 KiB
Go
package stack
|
|
|
|
import (
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/docker/cli/cli/config/configfile"
|
|
"github.com/docker/cli/internal/test"
|
|
"github.com/docker/cli/internal/test/builders"
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/swarm"
|
|
"github.com/pkg/errors"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
"gotest.tools/v3/golden"
|
|
)
|
|
|
|
func TestStackServicesErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
args []string
|
|
flags map[string]string
|
|
serviceListFunc func(options types.ServiceListOptions) ([]swarm.Service, error)
|
|
nodeListFunc func(options types.NodeListOptions) ([]swarm.Node, error)
|
|
taskListFunc func(options types.TaskListOptions) ([]swarm.Task, error)
|
|
expectedError string
|
|
}{
|
|
{
|
|
args: []string{"foo"},
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return nil, errors.Errorf("error getting services")
|
|
},
|
|
expectedError: "error getting services",
|
|
},
|
|
{
|
|
args: []string{"foo"},
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{*builders.Service(builders.GlobalService())}, nil
|
|
},
|
|
nodeListFunc: func(options types.NodeListOptions) ([]swarm.Node, error) {
|
|
return nil, errors.Errorf("error getting nodes")
|
|
},
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
|
return []swarm.Task{*builders.Task()}, nil
|
|
},
|
|
expectedError: "error getting nodes",
|
|
},
|
|
{
|
|
args: []string{"foo"},
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{*builders.Service(builders.GlobalService())}, nil
|
|
},
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
|
return nil, errors.Errorf("error getting tasks")
|
|
},
|
|
expectedError: "error getting tasks",
|
|
},
|
|
{
|
|
args: []string{"foo"},
|
|
flags: map[string]string{
|
|
"format": "{{invalid format}}",
|
|
},
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{*builders.Service()}, nil
|
|
},
|
|
expectedError: "template parsing error",
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
tc := tc
|
|
t.Run(tc.expectedError, func(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
serviceListFunc: tc.serviceListFunc,
|
|
nodeListFunc: tc.nodeListFunc,
|
|
taskListFunc: tc.taskListFunc,
|
|
})
|
|
cmd := newServicesCommand(cli)
|
|
cmd.SetArgs(tc.args)
|
|
for key, value := range tc.flags {
|
|
assert.Check(t, cmd.Flags().Set(key, value))
|
|
}
|
|
cmd.SetOut(io.Discard)
|
|
assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRunServicesWithEmptyName(t *testing.T) {
|
|
cmd := newServicesCommand(test.NewFakeCli(&fakeClient{}))
|
|
cmd.SetArgs([]string{"' '"})
|
|
cmd.SetOut(io.Discard)
|
|
|
|
assert.ErrorContains(t, cmd.Execute(), `invalid stack name: "' '"`)
|
|
}
|
|
|
|
func TestStackServicesEmptyServiceList(t *testing.T) {
|
|
fakeCli := test.NewFakeCli(&fakeClient{
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{}, nil
|
|
},
|
|
})
|
|
cmd := newServicesCommand(fakeCli)
|
|
cmd.SetArgs([]string{"foo"})
|
|
assert.NilError(t, cmd.Execute())
|
|
assert.Check(t, is.Equal("", fakeCli.OutBuffer().String()))
|
|
assert.Check(t, is.Equal("Nothing found in stack: foo\n", fakeCli.ErrBuffer().String()))
|
|
}
|
|
|
|
func TestStackServicesWithQuietOption(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{*builders.Service(builders.ServiceID("id-foo"))}, nil
|
|
},
|
|
})
|
|
cmd := newServicesCommand(cli)
|
|
assert.Check(t, cmd.Flags().Set("quiet", "true"))
|
|
cmd.SetArgs([]string{"foo"})
|
|
assert.NilError(t, cmd.Execute())
|
|
golden.Assert(t, cli.OutBuffer().String(), "stack-services-with-quiet-option.golden")
|
|
}
|
|
|
|
func TestStackServicesWithFormat(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{
|
|
*builders.Service(builders.ServiceName("service-name-foo")),
|
|
}, nil
|
|
},
|
|
})
|
|
cmd := newServicesCommand(cli)
|
|
cmd.SetArgs([]string{"foo"})
|
|
assert.Check(t, cmd.Flags().Set("format", "{{ .Name }}"))
|
|
assert.NilError(t, cmd.Execute())
|
|
golden.Assert(t, cli.OutBuffer().String(), "stack-services-with-format.golden")
|
|
}
|
|
|
|
func TestStackServicesWithConfigFormat(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{
|
|
*builders.Service(builders.ServiceName("service-name-foo")),
|
|
}, nil
|
|
},
|
|
})
|
|
cli.SetConfigFile(&configfile.ConfigFile{
|
|
ServicesFormat: "{{ .Name }}",
|
|
})
|
|
cmd := newServicesCommand(cli)
|
|
cmd.SetArgs([]string{"foo"})
|
|
assert.NilError(t, cmd.Execute())
|
|
golden.Assert(t, cli.OutBuffer().String(), "stack-services-with-config-format.golden")
|
|
}
|
|
|
|
func TestStackServicesWithoutFormat(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
serviceListFunc: func(options types.ServiceListOptions) ([]swarm.Service, error) {
|
|
return []swarm.Service{*builders.Service(
|
|
builders.ServiceName("name-foo"),
|
|
builders.ServiceID("id-foo"),
|
|
builders.ReplicatedService(2),
|
|
builders.ServiceImage("busybox:latest"),
|
|
builders.ServicePort(swarm.PortConfig{
|
|
PublishMode: swarm.PortConfigPublishModeIngress,
|
|
PublishedPort: 0,
|
|
TargetPort: 3232,
|
|
Protocol: swarm.PortConfigProtocolTCP,
|
|
}),
|
|
)}, nil
|
|
},
|
|
})
|
|
cmd := newServicesCommand(cli)
|
|
cmd.SetArgs([]string{"foo"})
|
|
assert.NilError(t, cmd.Execute())
|
|
golden.Assert(t, cli.OutBuffer().String(), "stack-services-without-format.golden")
|
|
}
|