cli/registry/client/endpoint.go:128:34: fmt.Sprintf can be replaced with string concatenation (perfsprint)
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", th.token))
^
cli/command/telemetry_docker.go:88:14: fmt.Sprintf can be replaced with string concatenation (perfsprint)
endpoint = fmt.Sprintf("unix://%s", path.Join(u.Host, u.Path))
^
cli/command/cli_test.go:195:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
opts := &flags.ClientOptions{Hosts: []string{fmt.Sprintf("unix://%s", socket)}}
^
cli/command/registry_test.go:59:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
inputServerAddress: fmt.Sprintf("https://%s", testAuthConfigs[1].ServerAddress),
^
cli/command/container/opts_test.go:338:35: fmt.Sprintf can be replaced with string concatenation (perfsprint)
if config, _, _ := mustParse(t, fmt.Sprintf("--hostname=%s", hostname)); config.Hostname != expectedHostname {
^
cli/command/context/options.go:79:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
errs = append(errs, fmt.Sprintf("%s: unrecognized config key", k))
^
cli/command/image/build.go:461:68: fmt.Sprintf can be replaced with string concatenation (perfsprint)
line = dockerfileFromLinePattern.ReplaceAllLiteralString(line, fmt.Sprintf("FROM %s", reference.FamiliarString(trustedRef)))
^
cli/command/image/remove_test.go:21:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("Error: No such image: %s", n.imageID)
^
cli/command/image/build/context.go:229:102: fmt.Sprintf can be replaced with string concatenation (perfsprint)
progReader := progress.NewProgressReader(response.Body, progressOutput, response.ContentLength, "", fmt.Sprintf("Downloading build context from remote url: %s", remoteURL))
^
cli/command/service/logs.go:215:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
taskName += fmt.Sprintf(".%s", task.ID)
^
cli/command/service/logs.go:217:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
taskName += fmt.Sprintf(".%s", stringid.TruncateID(task.ID))
^
cli/command/service/progress/progress_test.go:877:18: fmt.Sprintf can be replaced with string concatenation (perfsprint)
ID: fmt.Sprintf("task%s", nodeID),
^
cli/command/stack/swarm/remove.go:61:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
errs = append(errs, fmt.Sprintf("Failed to remove some resources from stack: %s", namespace))
^
cli/command/swarm/ipnet_slice_test.go:32:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
arg := fmt.Sprintf("--cidrs=%s", strings.Join(vals, ","))
^
cli/command/swarm/ipnet_slice_test.go:137:30: fmt.Sprintf can be replaced with string concatenation (perfsprint)
if err := f.Parse([]string{fmt.Sprintf("--cidrs=%s", strings.Join(test.FlagArg, ","))}); err != nil {
^
cli/compose/schema/schema.go:105:11: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("must be a %s", humanReadableType(expectedType))
^
cli/manifest/store/store.go:165:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("No such manifest: %s", n.object)
^
e2e/image/push_test.go:340:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_ROOT_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:341:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_TARGETS_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:342:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_SNAPSHOT_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:343:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_DELEGATION_PASSPHRASE=%s", pwd),
^
e2e/plugin/trust_test.go:23:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
pluginName := fmt.Sprintf("%s/plugin-content-trust", registryPrefix)
^
e2e/plugin/trust_test.go:53:8: fmt.Sprintf can be replaced with string concatenation (perfsprint)
Out: fmt.Sprintf("Installed plugin %s", pluginName),
^
e2e/trust/revoke_test.go:62:57: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.RunCommand("docker", "tag", fixtures.AlpineImage, fmt.Sprintf("%s:v1", revokeRepo)).Assert(t, icmd.Success)
^
e2e/trust/revoke_test.go:64:49: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.Command("docker", "-D", "trust", "sign", fmt.Sprintf("%s:v1", revokeRepo)),
^
e2e/trust/revoke_test.go:68:58: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.RunCommand("docker", "tag", fixtures.BusyboxImage, fmt.Sprintf("%s:v2", revokeRepo)).Assert(t, icmd.Success)
^
e2e/trust/revoke_test.go:70:49: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.Command("docker", "-D", "trust", "sign", fmt.Sprintf("%s:v2", revokeRepo)),
^
e2e/trust/sign_test.go:36:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.AlpineSha)))
^
e2e/trust/sign_test.go:53:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.BusyboxSha)))
^
e2e/trust/sign_test.go:65:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.AlpineSha)))
^
opts/file.go:21:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("poorly formatted environment: %s", e.msg)
^
opts/hosts_test.go:26:31: fmt.Sprintf can be replaced with string concatenation (perfsprint)
"tcp://host:": fmt.Sprintf("tcp://host:%s", defaultHTTPPort),
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
181 lines
4.3 KiB
Go
181 lines
4.3 KiB
Go
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
|
|
//go:build go1.19
|
|
|
|
package schema
|
|
|
|
import (
|
|
"embed"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/xeipuuv/gojsonschema"
|
|
)
|
|
|
|
const (
|
|
defaultVersion = "3.13"
|
|
versionField = "version"
|
|
)
|
|
|
|
type portsFormatChecker struct{}
|
|
|
|
func (checker portsFormatChecker) IsFormat(_ any) bool {
|
|
// TODO: implement this
|
|
return true
|
|
}
|
|
|
|
type durationFormatChecker struct{}
|
|
|
|
func (checker durationFormatChecker) IsFormat(input any) bool {
|
|
value, ok := input.(string)
|
|
if !ok {
|
|
return false
|
|
}
|
|
_, err := time.ParseDuration(value)
|
|
return err == nil
|
|
}
|
|
|
|
func init() {
|
|
gojsonschema.FormatCheckers.Add("expose", portsFormatChecker{})
|
|
gojsonschema.FormatCheckers.Add("ports", portsFormatChecker{})
|
|
gojsonschema.FormatCheckers.Add("duration", durationFormatChecker{})
|
|
}
|
|
|
|
// Version returns the version of the config, defaulting to the latest "3.x"
|
|
// version (3.13). If only the major version "3" is specified, it is used as
|
|
// version "3.x" and returns the default version (latest 3.x).
|
|
func Version(config map[string]any) string {
|
|
version, ok := config[versionField]
|
|
if !ok {
|
|
return defaultVersion
|
|
}
|
|
return normalizeVersion(fmt.Sprintf("%v", version))
|
|
}
|
|
|
|
func normalizeVersion(version string) string {
|
|
switch version {
|
|
case "", "3":
|
|
return defaultVersion
|
|
default:
|
|
return version
|
|
}
|
|
}
|
|
|
|
//go:embed data/config_schema_v*.json
|
|
var schemas embed.FS
|
|
|
|
// Validate uses the jsonschema to validate the configuration
|
|
func Validate(config map[string]any, version string) error {
|
|
version = normalizeVersion(version)
|
|
schemaData, err := schemas.ReadFile("data/config_schema_v" + version + ".json")
|
|
if err != nil {
|
|
return errors.Errorf("unsupported Compose file version: %s", version)
|
|
}
|
|
|
|
schemaLoader := gojsonschema.NewStringLoader(string(schemaData))
|
|
dataLoader := gojsonschema.NewGoLoader(config)
|
|
|
|
result, err := gojsonschema.Validate(schemaLoader, dataLoader)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if !result.Valid() {
|
|
return toError(result)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func toError(result *gojsonschema.Result) error {
|
|
err := getMostSpecificError(result.Errors())
|
|
return err
|
|
}
|
|
|
|
const (
|
|
jsonschemaOneOf = "number_one_of"
|
|
jsonschemaAnyOf = "number_any_of"
|
|
)
|
|
|
|
func getDescription(err validationError) string {
|
|
switch err.parent.Type() {
|
|
case "invalid_type":
|
|
if expectedType, ok := err.parent.Details()["expected"].(string); ok {
|
|
return "must be a " + humanReadableType(expectedType)
|
|
}
|
|
case jsonschemaOneOf, jsonschemaAnyOf:
|
|
if err.child == nil {
|
|
return err.parent.Description()
|
|
}
|
|
return err.child.Description()
|
|
}
|
|
return err.parent.Description()
|
|
}
|
|
|
|
func humanReadableType(definition string) string {
|
|
if definition[0:1] == "[" {
|
|
allTypes := strings.Split(definition[1:len(definition)-1], ",")
|
|
for i, t := range allTypes {
|
|
allTypes[i] = humanReadableType(t)
|
|
}
|
|
return fmt.Sprintf(
|
|
"%s or %s",
|
|
strings.Join(allTypes[0:len(allTypes)-1], ", "),
|
|
allTypes[len(allTypes)-1],
|
|
)
|
|
}
|
|
if definition == "object" {
|
|
return "mapping"
|
|
}
|
|
if definition == "array" {
|
|
return "list"
|
|
}
|
|
return definition
|
|
}
|
|
|
|
type validationError struct {
|
|
parent gojsonschema.ResultError
|
|
child gojsonschema.ResultError
|
|
}
|
|
|
|
func (err validationError) Error() string {
|
|
description := getDescription(err)
|
|
return fmt.Sprintf("%s %s", err.parent.Field(), description)
|
|
}
|
|
|
|
func getMostSpecificError(errs []gojsonschema.ResultError) validationError {
|
|
mostSpecificError := 0
|
|
for i, err := range errs {
|
|
if specificity(err) > specificity(errs[mostSpecificError]) {
|
|
mostSpecificError = i
|
|
continue
|
|
}
|
|
|
|
if specificity(err) == specificity(errs[mostSpecificError]) {
|
|
// Invalid type errors win in a tie-breaker for most specific field name
|
|
if err.Type() == "invalid_type" && errs[mostSpecificError].Type() != "invalid_type" {
|
|
mostSpecificError = i
|
|
}
|
|
}
|
|
}
|
|
|
|
if mostSpecificError+1 == len(errs) {
|
|
return validationError{parent: errs[mostSpecificError]}
|
|
}
|
|
|
|
switch errs[mostSpecificError].Type() {
|
|
case "number_one_of", "number_any_of":
|
|
return validationError{
|
|
parent: errs[mostSpecificError],
|
|
child: errs[mostSpecificError+1],
|
|
}
|
|
default:
|
|
return validationError{parent: errs[mostSpecificError]}
|
|
}
|
|
}
|
|
|
|
func specificity(err gojsonschema.ResultError) int {
|
|
return len(strings.Split(err.Field(), "."))
|
|
}
|