b9a7f35e02
The validation functions to test for the number of passed arguments did not
pluralize `argument(s)`, and used `argument(s)` in all cases.
This patch adds a simple `pluralize()` helper to improve this.
Before this change, `argument(s)` was used in all cases:
$ docker container ls foobar
"docker container ls" accepts no argument(s).
$ docker network create one two
"docker network create" requires exactly 1 argument(s).
$ docker network connect
"docker network connect" requires exactly 2 argument(s).
$ docker volume create one two
"docker volume create" requires at most 1 argument(s).
After this change, `argument(s)` is properly singularized or plurarized:
$ docker container ls foobar
"docker container ls" accepts no arguments.
$ docker network create one two
"docker network create" requires exactly 1 argument.
$ docker network connect
"docker network connect" requires exactly 2 arguments.
$ docker volume create one two
"docker volume create" requires at most 1 argument.
Test cases were updated accordingly.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
67 lines
1.9 KiB
Go
67 lines
1.9 KiB
Go
package checkpoint
|
|
|
|
import (
|
|
"bytes"
|
|
"io/ioutil"
|
|
"testing"
|
|
|
|
"github.com/docker/cli/cli/internal/test"
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/pkg/testutil"
|
|
"github.com/pkg/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCheckpointRemoveErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
args []string
|
|
checkpointDeleteFunc func(container string, options types.CheckpointDeleteOptions) error
|
|
expectedError string
|
|
}{
|
|
{
|
|
args: []string{"too-few-arguments"},
|
|
expectedError: "requires exactly 2 arguments",
|
|
},
|
|
{
|
|
args: []string{"too", "many", "arguments"},
|
|
expectedError: "requires exactly 2 arguments",
|
|
},
|
|
{
|
|
args: []string{"foo", "bar"},
|
|
checkpointDeleteFunc: func(container string, options types.CheckpointDeleteOptions) error {
|
|
return errors.Errorf("error deleting checkpoint")
|
|
},
|
|
expectedError: "error deleting checkpoint",
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
cli := test.NewFakeCliWithOutput(&fakeClient{
|
|
checkpointDeleteFunc: tc.checkpointDeleteFunc,
|
|
}, &bytes.Buffer{})
|
|
cmd := newRemoveCommand(cli)
|
|
cmd.SetArgs(tc.args)
|
|
cmd.SetOutput(ioutil.Discard)
|
|
testutil.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
}
|
|
}
|
|
|
|
func TestCheckpointRemoveWithOptions(t *testing.T) {
|
|
var containerID, checkpointID, checkpointDir string
|
|
cli := test.NewFakeCliWithOutput(&fakeClient{
|
|
checkpointDeleteFunc: func(container string, options types.CheckpointDeleteOptions) error {
|
|
containerID = container
|
|
checkpointID = options.CheckpointID
|
|
checkpointDir = options.CheckpointDir
|
|
return nil
|
|
},
|
|
}, &bytes.Buffer{})
|
|
cmd := newRemoveCommand(cli)
|
|
cmd.SetArgs([]string{"container-foo", "checkpoint-bar"})
|
|
cmd.Flags().Set("checkpoint-dir", "/dir/foo")
|
|
assert.NoError(t, cmd.Execute())
|
|
assert.Equal(t, "container-foo", containerID)
|
|
assert.Equal(t, "checkpoint-bar", checkpointID)
|
|
assert.Equal(t, "/dir/foo", checkpointDir)
|
|
}
|