0adaf6be3b
This replaces the visitAll recursive function with a test that verifies that the option is set for all commands and subcommands, so that it doesn't have to be modified at runtime. We currently still have to loop over all functions for the setValidateArgs call, but that can be looked at separately. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
68 lines
1.9 KiB
Go
68 lines
1.9 KiB
Go
package volume
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
"github.com/docker/cli/cli"
|
|
"github.com/docker/cli/cli/command"
|
|
"github.com/docker/cli/cli/command/completion"
|
|
"github.com/moby/moby/api/types/volume"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
func newUpdateCommand(dockerCLI command.Cli) *cobra.Command {
|
|
var availability string
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "update [OPTIONS] [VOLUME]",
|
|
Short: "Update a volume (cluster volumes only)",
|
|
Args: cli.ExactArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
return runUpdate(cmd.Context(), dockerCLI, args[0], availability, cmd.Flags())
|
|
},
|
|
Annotations: map[string]string{
|
|
"version": "1.42",
|
|
"swarm": "manager",
|
|
},
|
|
ValidArgsFunction: completion.VolumeNames(dockerCLI),
|
|
DisableFlagsInUseLine: true,
|
|
}
|
|
|
|
flags := cmd.Flags()
|
|
flags.StringVar(&availability, "availability", "active", `Cluster Volume availability ("active", "pause", "drain")`)
|
|
flags.SetAnnotation("availability", "version", []string{"1.42"})
|
|
flags.SetAnnotation("availability", "swarm", []string{"manager"})
|
|
|
|
return cmd
|
|
}
|
|
|
|
func runUpdate(ctx context.Context, dockerCli command.Cli, volumeID, availability string, flags *pflag.FlagSet) error {
|
|
// TODO(dperny): For this earliest version, the only thing that can be
|
|
// updated is Availability, which is necessary because to delete a cluster
|
|
// volume, the availability must first be set to "drain"
|
|
|
|
apiClient := dockerCli.Client()
|
|
|
|
vol, _, err := apiClient.VolumeInspectWithRaw(ctx, volumeID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if vol.ClusterVolume == nil {
|
|
return errors.New("can only update cluster volumes")
|
|
}
|
|
|
|
if flags.Changed("availability") {
|
|
vol.ClusterVolume.Spec.Availability = volume.Availability(availability)
|
|
}
|
|
|
|
return apiClient.VolumeUpdate(
|
|
ctx, vol.ClusterVolume.ID, vol.ClusterVolume.Version,
|
|
volume.UpdateOptions{
|
|
Spec: &vol.ClusterVolume.Spec,
|
|
},
|
|
)
|
|
}
|