8aa5280c2b
All LVM actions in the devicemapper library are asyncronous, involving a call to a task enqueue function (dm_run_task) and a wait on a resultant udev event (UdevWait). Currently devmapper.go defers all calls to UdevWait, which discards the return value. While it still generates an error message in the log (if debugging is enabled), the calling thread is still allowed to continue as if no error has occured, leading to subsequent errors, and significant confusion when debugging, due to those subsequent errors. Given that there is no risk of panic between the task submission and the wait operation, it seems more reasonable to preform the UdevWait inline at the end of any given lvm action so that errors can be caught and returned before docker can continue and create additional failures. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Upstream-commit: 5206d45e70512f5fc06006047fb67b2f478b304d Component: engine
pkg/ is a collection of utility packages used by the Docker project without being specific to its internals.
Utility packages are kept separate from the docker core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Docker organization, to facilitate re-use by other projects. However that is not the priority.
The directory pkg is named after the same directory in the camlistore project. Since Brad is a core
Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!
Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!