b1397d2034
This functionality has been fixed by 7bca93218291767c5dd8782de0ad630dbcda9995 but then it has been broken again by a793564b2591035aec5412fbcbcccf220c773a4c and finally refixed here. Basically the functionality was to prompt for login when trying to pull from the official docker hub. Signed-off-by: Antonio Murdaca <runcom@redhat.com> Upstream-commit: 4316ae2ed33d158e1d8d994646a75e25a70d9320 Component: engine
82 lines
2.3 KiB
Go
82 lines
2.3 KiB
Go
package httputils
|
|
|
|
import (
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
)
|
|
|
|
// httpStatusError is an interface
|
|
// that errors with custom status codes
|
|
// implement to tell the api layer
|
|
// which response status to set.
|
|
type httpStatusError interface {
|
|
HTTPErrorStatusCode() int
|
|
}
|
|
|
|
// inputValidationError is an interface
|
|
// that errors generated by invalid
|
|
// inputs can implement to tell the
|
|
// api layer to set a 400 status code
|
|
// in the response.
|
|
type inputValidationError interface {
|
|
IsValidationError() bool
|
|
}
|
|
|
|
// GetHTTPErrorStatusCode retrieve status code from error message
|
|
func GetHTTPErrorStatusCode(err error) int {
|
|
if err == nil {
|
|
logrus.WithFields(logrus.Fields{"error": err}).Error("unexpected HTTP error handling")
|
|
return http.StatusInternalServerError
|
|
}
|
|
|
|
var statusCode int
|
|
errMsg := err.Error()
|
|
|
|
switch e := err.(type) {
|
|
case httpStatusError:
|
|
statusCode = e.HTTPErrorStatusCode()
|
|
case inputValidationError:
|
|
statusCode = http.StatusBadRequest
|
|
default:
|
|
// FIXME: this is brittle and should not be necessary, but we still need to identify if
|
|
// there are errors falling back into this logic.
|
|
// If we need to differentiate between different possible error types,
|
|
// we should create appropriate error types that implement the httpStatusError interface.
|
|
errStr := strings.ToLower(errMsg)
|
|
for keyword, status := range map[string]int{
|
|
"not found": http.StatusNotFound,
|
|
"no such": http.StatusNotFound,
|
|
"bad parameter": http.StatusBadRequest,
|
|
"conflict": http.StatusConflict,
|
|
"impossible": http.StatusNotAcceptable,
|
|
"wrong login/password": http.StatusUnauthorized,
|
|
"unauthorized": http.StatusUnauthorized,
|
|
"hasn't been activated": http.StatusForbidden,
|
|
} {
|
|
if strings.Contains(errStr, keyword) {
|
|
statusCode = status
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
if statusCode == 0 {
|
|
statusCode = http.StatusInternalServerError
|
|
}
|
|
|
|
return statusCode
|
|
}
|
|
|
|
// WriteError decodes a specific docker error and sends it in the response.
|
|
func WriteError(w http.ResponseWriter, err error) {
|
|
if err == nil || w == nil {
|
|
logrus.WithFields(logrus.Fields{"error": err, "writer": w}).Error("unexpected HTTP error handling")
|
|
return
|
|
}
|
|
|
|
statusCode := GetHTTPErrorStatusCode(err)
|
|
http.Error(w, err.Error(), statusCode)
|
|
}
|