Sebastiaan van Stijn ab3f294aab do not ignore "volume in use" errors when force-delete ...

When using `docker volume rm -f`, all errors were ignored,
and volumes where Purged, even if they were still in
use by a container.

As a result, repeated calls to `docker volume rm -f`
actually removed the volume.

The `-f` option was implemented to ignore errors
in case a volume was already removed out-of-band
by a volume driver plugin.

This patch changes the remove function to not
ignore "volume in use" errors if `-f` is used.
Other errors are still ignored as before.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 9d521a4d2fbbeec0f672b986e294fd5f1c4d2f32
Component: engine

2017-03-01 16:36:43 +01:00

..

checker

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

daemon

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

environment

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

fixtures

Convert script shebangs from "#!/bin/bash" to "#!/usr/bin/env bash"

2017-02-13 11:01:54 -08:00

registry

Avoid defunct registry/notary processes during tests

2017-01-13 17:45:14 -08:00

request

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

requirement

Display only the name of the requirement…

2016-12-26 21:29:17 +01:00

benchmark_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

check_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

daemon_swarm_hack_test.go

Small cleanups on integration cli

2017-01-12 16:57:59 +01:00

docker_api_attach_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_api_auth_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_api_build_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_containers_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_create_test.go

validate healthcheck params in daemon side

2017-01-29 13:35:32 +08:00

docker_api_events_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_exec_resize_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_exec_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_images_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_info_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_api_inspect_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_api_inspect_unix_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_api_logs_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_network_test.go

Fix leaked connections in integration tests

2017-01-11 14:48:48 -08:00

docker_api_resize_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_api_stats_test.go

Merge pull request #31412 from vdemeester/integration-request-pass

2017-03-01 14:15:50 +01:00

docker_api_stats_unix_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_swarm_node_test.go

split docker_api_swarm_test.go into multiple files

2017-02-11 00:18:01 +08:00

docker_api_swarm_secret_test.go

split docker_api_swarm_test.go into multiple files

2017-02-11 00:18:01 +08:00

docker_api_swarm_service_test.go

split docker_api_swarm_test.go into multiple files

2017-02-11 00:18:01 +08:00

docker_api_swarm_test.go

Vendor swarmkit 46bbd41

2017-02-27 11:51:00 -08:00

docker_api_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_api_update_unix_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_api_version_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_api_volumes_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_cli_attach_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_attach_unix_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_authz_plugin_v2_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_authz_unix_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_build_test.go

fix wrong foo to zzz in docker_cli_build_test.go

2017-03-01 17:49:54 +08:00

docker_cli_build_unix_test.go

fix some ineffectual assignments

2017-01-24 11:16:19 +01:00

docker_cli_by_digest_test.go

fix DockerSchema1RegistrySuite.TestPullFailsWithAlteredLayer

2017-02-17 10:34:33 -08:00

docker_cli_commit_test.go

fix some ineffectual assignments

2017-01-24 11:16:19 +01:00

docker_cli_config_test.go

Update trustedCmd to be compatible with testutil/cmd

2017-01-09 11:07:05 +01:00

docker_cli_cp_from_container_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_cp_test.go

Remove most of the runCommandWithOutput from integration tests

2017-01-30 10:54:06 +01:00

docker_cli_cp_to_container_test.go

fix some ineffectual assignments

2017-01-24 11:16:19 +01:00

docker_cli_cp_to_container_unix_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_cp_utils.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_create_test.go

Remove use of forked reference package for cli

2017-01-19 16:04:50 -08:00

docker_cli_create_unix_test.go

validate mount path for tmpfs

2017-01-20 06:01:48 +00:00

docker_cli_daemon_plugins_test.go

Add capability filter to docker plugin ls

2017-01-27 07:32:22 -08:00

docker_cli_daemon_test.go

Merge pull request #29552 from dnephin/fix-build-with-log-driver

2017-02-07 15:47:41 -05:00

docker_cli_diff_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_events_test.go

Limit TestEventsLimit to 4 concurrent containers on Windows

2017-01-30 11:04:52 -08:00

docker_cli_events_unix_test.go

Update opts.MemBytes to disable default, and move docker run/create/build to use opts.MemBytes

2017-01-27 12:17:06 -08:00

docker_cli_exec_test.go

Merge pull request #30537 from DiSiqueira/asserting_error

2017-02-01 16:08:20 +01:00

docker_cli_exec_unix_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_experimental_test.go

Small cleanups on integration cli

2017-01-12 16:57:59 +01:00

docker_cli_export_import_test.go

Update trustedCmd to be compatible with testutil/cmd

2017-01-09 11:07:05 +01:00

docker_cli_external_graphdriver_unix_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_external_volume_driver_unix_test.go

Add unit tests to cli/command/volume package

2017-02-27 18:39:35 +01:00

docker_cli_health_test.go

validate healthcheck params in daemon side

2017-01-29 13:35:32 +08:00

docker_cli_help_test.go

Wrap output of docker cli --help

2017-02-03 11:05:49 +00:00

docker_cli_history_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_images_test.go

Use distribution reference

2017-02-07 11:08:37 -08:00

docker_cli_import_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_info_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_info_unix_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_inspect_test.go

Merge pull request #30165 from xulike666/fix-typo-6/36

2017-01-19 17:21:22 +01:00

docker_cli_kill_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_cli_links_test.go

Remove most of the runCommandWithOutput from integration tests

2017-01-30 10:54:06 +01:00

docker_cli_links_unix_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_login_test.go

Merge pull request #29799 from vdemeester/integration-registry-package

2017-01-02 15:37:09 +01:00

docker_cli_logout_test.go

Merge pull request #29799 from vdemeester/integration-registry-package

2017-01-02 15:37:09 +01:00

docker_cli_logs_bench_test.go

Fixes some issues with jsonfile write/read

2016-03-21 11:05:58 -04:00

docker_cli_logs_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_nat_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_netmode_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_network_unix_test.go

Revert "Fix IT case for network name validation"

2017-02-02 15:38:12 -08:00

docker_cli_oom_killed_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_pause_test.go

Remove most of the runCommandWithOutput from integration tests

2017-01-30 10:54:06 +01:00

docker_cli_plugins_test.go

Make propagated mount persist outside rootfs

2017-02-03 16:22:58 -05:00

docker_cli_port_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_proxy_test.go

Update trustedCmd to be compatible with testutil/cmd

2017-01-09 11:07:05 +01:00

docker_cli_prune_unix_test.go

Add --filter until=<timestamp> for docker container/image prune

2017-01-04 14:16:42 -08:00

docker_cli_ps_test.go

Bump go-units

2017-02-07 21:58:56 +01:00

docker_cli_pull_local_test.go

fix some ineffectual assignments

2017-01-24 11:16:19 +01:00

docker_cli_pull_test.go

Block Windows images on Linux

2017-02-02 11:07:30 -08:00

docker_cli_pull_trusted_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_push_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_registry_user_agent_test.go

fix typo

2017-01-19 15:52:28 +08:00

docker_cli_rename_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_restart_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_rm_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_rmi_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_run_test.go

Merge pull request #30654 from Microsoft/jjh/unifyworkdir

2017-02-03 00:37:54 -08:00

docker_cli_run_unix_test.go

rectify the function name used by note

2017-02-22 16:13:45 +08:00

docker_cli_save_load_test.go

Remove most of the runCommandWithOutput from integration tests

2017-01-30 10:54:06 +01:00

docker_cli_save_load_unix_test.go

Remove most of the runCommandWithOutput from integration tests

2017-01-30 10:54:06 +01:00

docker_cli_search_test.go

fix some ineffectual assignments

2017-01-24 11:16:19 +01:00

docker_cli_secret_create_test.go

Move secret name or ID prefix resolving from client to daemon

2017-01-27 10:40:05 -08:00

docker_cli_secret_inspect_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_service_create_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_service_health_test.go

Small cleanups on integration cli

2017-01-12 16:57:59 +01:00

docker_cli_service_logs_experimental_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_service_scale_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_service_update_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_sni_test.go

Disable flakey TestClientSetsTLSServerName

2016-02-02 19:56:31 -08:00

docker_cli_stack_test.go

Add missing build tag for stack tests.

2017-02-01 13:25:37 -05:00

docker_cli_start_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_stats_test.go

Send "Name" and "ID" when stating stopped containers

2017-02-09 09:46:59 +08:00

docker_cli_stop_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_swarm_test.go

Release the network attachment on allocation failure

2017-02-16 05:21:06 -08:00

docker_cli_swarm_unix_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_tag_test.go

Clean more build utils in integration cli

2017-01-17 15:42:38 +01:00

docker_cli_top_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_update_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_cli_update_unix_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_cli_userns_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_v2_only_test.go

Fix leaked connections in integration tests

2017-01-11 14:48:48 -08:00

docker_cli_version_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

docker_cli_volume_test.go

do not ignore "volume in use" errors when force-delete

2017-03-01 16:36:43 +01:00

docker_cli_wait_test.go

Update trustedCmd to be compatible with testutil/cmd

2017-01-09 11:07:05 +01:00

docker_deprecated_api_v124_test.go

Convert request.SockRequestRaw to appropriate methods

2017-02-28 17:12:30 +01:00

docker_deprecated_api_v124_unix_test.go

Add a new request package in integration-cli

2017-01-03 11:49:30 +01:00

docker_experimental_network_test.go

Small cleanups on integration cli

2017-01-12 16:57:59 +01:00

docker_hub_pull_suite_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

docker_utils_test.go

Remove most of the runCommandWithOutput from integration tests

2017-01-30 10:54:06 +01:00

events_utils_test.go

Remove pkg/integration and move it to testutil or integration-cli

2016-12-30 18:26:34 +01:00

fixtures_linux_daemon_test.go

Block obsolete socket families in the default seccomp profile

2017-01-17 17:50:44 +00:00

fixtures_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

requirements_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

requirements_unix_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

test_vars_exec_test.go

Introduce a environment package in integration-cli

2016-12-29 11:00:50 +01:00

test_vars_noexec_test.go

Introduce a environment package in integration-cli

2016-12-29 11:00:50 +01:00

test_vars_noseccomp_test.go

Introduce a environment package in integration-cli

2016-12-29 11:00:50 +01:00

test_vars_seccomp_test.go

Introduce a environment package in integration-cli

2016-12-29 11:00:50 +01:00

test_vars_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00

test_vars_unix_test.go

Introduce a environment package in integration-cli

2016-12-29 11:00:50 +01:00

test_vars_windows_test.go

Introduce a environment package in integration-cli

2016-12-29 11:00:50 +01:00

trust_server_test.go

Merge pull request #30151 from tonistiigi/fix-defunct

2017-01-16 08:55:16 +01:00

utils_test.go

Use testEnv methods and remove most of the global variables

2017-01-17 12:39:08 +01:00