8b12ac14d7
Currently, the HostConfig is only passed from the CLI to Docker only when issuing a docker create, but not when doing a docker run. In the near future, in order to allocate ports at creation time rather than start time, we will need to have the HostConfig readily available at container creation. This PR makes the client always pass the HostConfig when creating a container (regardless of whether it's for a run or create). Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com> Upstream-commit: 1df87b95066198c30312147393c18e0be0564fd0 Component: engine
Legacy integration tests
./integration contains Docker's legacy integration tests.
It is DEPRECATED and will eventually be removed.
If you are a CONTRIBUTOR and want to add a test:
-
Consider mocking out side effects and contributing a unit test in the subsystem you're modifying. For example, the remote API has unit tests in
./api/server/server_unit_tests.go. The events subsystem has unit tests in./events/events_test.go. And so on. -
For end-to-end integration tests, please contribute to
./integration-cli.
If you are a MAINTAINER
Please don't allow patches adding new tests to ./integration.
If you are LOOKING FOR A WAY TO HELP
Please consider porting tests away from ./integration and into either unit tests or CLI tests.
Any help will be greatly appreciated!