f08252c10a
These wrappers were added to abstract stack deploy to k8s and swarm. Now
that support for deploying to k8s was removed, we can remove these wrappers.
This deprecates:
- RunDeploy()
- RunPs()
- RunRemove()
- GetServices()
This also addresses some linting failers, due to these functions having
unused arguments:
cli/command/stack/deploy.go:51:39: unused-parameter: parameter 'flags' seems to be unused, consider removing or renaming it as _ (revive)
func RunDeploy(dockerCli command.Cli, flags *pflag.FlagSet, config *composetypes.Config, opts options.Deploy) error {
^
cli/command/stack/ps.go:42:35: unused-parameter: parameter 'flags' seems to be unused, consider removing or renaming it as _ (revive)
func RunPs(dockerCli command.Cli, flags *pflag.FlagSet, opts options.PS) error {
^
cli/command/stack/remove.go:35:39: unused-parameter: parameter 'flags' seems to be unused, consider removing or renaming it as _ (revive)
func RunRemove(dockerCli command.Cli, flags *pflag.FlagSet, opts options.Remove) error {
^
cli/command/stack/list.go:37:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
func RunList(cmd *cobra.Command, dockerCli command.Cli, opts options.List) error {
^
cli/command/stack/services.go:56:41: unused-parameter: parameter 'flags' seems to be unused, consider removing or renaming it as _ (revive)
func GetServices(dockerCli command.Cli, flags *pflag.FlagSet, opts options.Services) ([]swarmtypes.Service, error) {
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
47 lines
1.6 KiB
Go
47 lines
1.6 KiB
Go
package stack
|
|
|
|
import (
|
|
"github.com/docker/cli/cli"
|
|
"github.com/docker/cli/cli/command"
|
|
"github.com/docker/cli/cli/command/stack/options"
|
|
"github.com/docker/cli/cli/command/stack/swarm"
|
|
flagsHelper "github.com/docker/cli/cli/flags"
|
|
cliopts "github.com/docker/cli/opts"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
func newPsCommand(dockerCli command.Cli) *cobra.Command {
|
|
opts := options.PS{Filter: cliopts.NewFilterOpt()}
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "ps [OPTIONS] STACK",
|
|
Short: "List the tasks in the stack",
|
|
Args: cli.ExactArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
opts.Namespace = args[0]
|
|
if err := validateStackName(opts.Namespace); err != nil {
|
|
return err
|
|
}
|
|
return swarm.RunPS(dockerCli, opts)
|
|
},
|
|
ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
|
|
return completeNames(dockerCli)(cmd, args, toComplete)
|
|
},
|
|
}
|
|
flags := cmd.Flags()
|
|
flags.BoolVar(&opts.NoTrunc, "no-trunc", false, "Do not truncate output")
|
|
flags.BoolVar(&opts.NoResolve, "no-resolve", false, "Do not map IDs to Names")
|
|
flags.VarP(&opts.Filter, "filter", "f", "Filter output based on conditions provided")
|
|
flags.BoolVarP(&opts.Quiet, "quiet", "q", false, "Only display task IDs")
|
|
flags.StringVar(&opts.Format, "format", "", flagsHelper.FormatHelp)
|
|
return cmd
|
|
}
|
|
|
|
// RunPs performs a stack ps against the specified swarm cluster.
|
|
//
|
|
// Deprecated: use [swarm.RunPS] instead.
|
|
func RunPs(dockerCli command.Cli, _ *pflag.FlagSet, opts options.PS) error {
|
|
return swarm.RunPS(dockerCli, opts)
|
|
}
|