db827d583b
These tests were deliberately producing errors as part of the test, but
printing those errors could be confusing / make it more difficult to find
actual test-failures.
Before this patch:
=== RUN TestVolumeCreateErrors
Error: conflicting options: either specify --name or provide positional arg, not both
Error: "create" requires at most 1 argument.
See 'create --help'.
Usage: create [OPTIONS] [VOLUME] [flags]
Create a volume
Error: error creating volume
--- PASS: TestVolumeCreateErrors (0.00s)
PASS
With this patch applied:
=== RUN TestVolumeCreateErrors
--- PASS: TestVolumeCreateErrors (0.00s)
PASS
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
46 lines
1.0 KiB
Go
46 lines
1.0 KiB
Go
package volume
|
|
|
|
import (
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/docker/cli/internal/test"
|
|
"github.com/pkg/errors"
|
|
"gotest.tools/v3/assert"
|
|
)
|
|
|
|
func TestVolumeRemoveErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
args []string
|
|
volumeRemoveFunc func(volumeID string, force bool) error
|
|
expectedError string
|
|
}{
|
|
{
|
|
expectedError: "requires at least 1 argument",
|
|
},
|
|
{
|
|
args: []string{"nodeID"},
|
|
volumeRemoveFunc: func(volumeID string, force bool) error {
|
|
return errors.Errorf("error removing the volume")
|
|
},
|
|
expectedError: "error removing the volume",
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
cmd := newRemoveCommand(
|
|
test.NewFakeCli(&fakeClient{
|
|
volumeRemoveFunc: tc.volumeRemoveFunc,
|
|
}))
|
|
cmd.SetArgs(tc.args)
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetErr(io.Discard)
|
|
assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
}
|
|
}
|
|
|
|
func TestNodeRemoveMultiple(t *testing.T) {
|
|
cmd := newRemoveCommand(test.NewFakeCli(&fakeClient{}))
|
|
cmd.SetArgs([]string{"volume1", "volume2"})
|
|
assert.NilError(t, cmd.Execute())
|
|
}
|