eaa727c6e2
Remove some run functions and replace them with the unified run command. Remove DockerCmdWithStdoutStderr Remove many duplicate runCommand functions. Also add dockerCmdWithResult() Allow Result.Assert() to ignore the error message if an exit status is expected. Fix race in DockerSuite.TestDockerInspectMultipleNetwork Fix flaky test DockerSuite.TestRunInteractiveWithRestartPolicy Signed-off-by: Daniel Nephin <dnephin@docker.com> Upstream-commit: d7022f2b46589cb9d860219e1d8278351ba147c3 Component: engine
105 lines
2.5 KiB
Go
105 lines
2.5 KiB
Go
package cmd
|
|
|
|
import (
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/docker/docker/pkg/testutil/assert"
|
|
)
|
|
|
|
func TestRunCommand(t *testing.T) {
|
|
// TODO Windows: Port this test
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("Needs porting to Windows")
|
|
}
|
|
|
|
result := RunCommand("ls")
|
|
result.Assert(t, Expected{})
|
|
|
|
result = RunCommand("doesnotexists")
|
|
expectedError := `exec: "doesnotexists": executable file not found`
|
|
result.Assert(t, Expected{ExitCode: 127, Error: expectedError})
|
|
|
|
result = RunCommand("ls", "-z")
|
|
result.Assert(t, Expected{
|
|
ExitCode: 2,
|
|
Error: "exit status 2",
|
|
Err: "invalid option",
|
|
})
|
|
assert.Contains(t, result.Combined(), "invalid option")
|
|
}
|
|
|
|
func TestRunCommandWithCombined(t *testing.T) {
|
|
// TODO Windows: Port this test
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("Needs porting to Windows")
|
|
}
|
|
|
|
result := RunCommand("ls", "-a")
|
|
result.Assert(t, Expected{})
|
|
|
|
assert.Contains(t, result.Combined(), "..")
|
|
assert.Contains(t, result.Stdout(), "..")
|
|
}
|
|
|
|
func TestRunCommandWithTimeoutFinished(t *testing.T) {
|
|
// TODO Windows: Port this test
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("Needs porting to Windows")
|
|
}
|
|
|
|
result := RunCmd(Cmd{
|
|
Command: []string{"ls", "-a"},
|
|
Timeout: 50 * time.Millisecond,
|
|
})
|
|
result.Assert(t, Expected{Out: ".."})
|
|
}
|
|
|
|
func TestRunCommandWithTimeoutKilled(t *testing.T) {
|
|
// TODO Windows: Port this test
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("Needs porting to Windows")
|
|
}
|
|
|
|
command := []string{"sh", "-c", "while true ; do echo 1 ; sleep .1 ; done"}
|
|
result := RunCmd(Cmd{Command: command, Timeout: 500 * time.Millisecond})
|
|
result.Assert(t, Expected{Timeout: true})
|
|
|
|
ones := strings.Split(result.Stdout(), "\n")
|
|
assert.Equal(t, len(ones), 6)
|
|
}
|
|
|
|
func TestRunCommandWithErrors(t *testing.T) {
|
|
result := RunCommand("/foobar")
|
|
result.Assert(t, Expected{Error: "foobar", ExitCode: 127})
|
|
}
|
|
|
|
func TestRunCommandWithStdoutStderr(t *testing.T) {
|
|
result := RunCommand("echo", "hello", "world")
|
|
result.Assert(t, Expected{Out: "hello world\n", Err: None})
|
|
}
|
|
|
|
func TestRunCommandWithStdoutStderrError(t *testing.T) {
|
|
result := RunCommand("doesnotexists")
|
|
|
|
expected := `exec: "doesnotexists": executable file not found`
|
|
result.Assert(t, Expected{Out: None, Err: None, ExitCode: 127, Error: expected})
|
|
|
|
switch runtime.GOOS {
|
|
case "windows":
|
|
expected = "ls: unknown option"
|
|
default:
|
|
expected = "ls: invalid option"
|
|
}
|
|
|
|
result = RunCommand("ls", "-z")
|
|
result.Assert(t, Expected{
|
|
Out: None,
|
|
Err: expected,
|
|
ExitCode: 2,
|
|
Error: "exit status 2",
|
|
})
|
|
}
|