9dd012aa5d
I could either remove the name for these contexts, or make the fake functions
more accurately reflect the actual implementation (decided to go for the latter
one)
cli/command/secret/client_test.go:19:35: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *fakeClient) SecretCreate(ctx context.Context, spec swarm.SecretSpec) (types.SecretCreateResponse, error) {
^
cli/command/secret/client_test.go:26:43: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *fakeClient) SecretInspectWithRaw(ctx context.Context, id string) (swarm.Secret, []byte, error) {
^
cli/command/secret/client_test.go:33:33: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *fakeClient) SecretList(ctx context.Context, options types.SecretListOptions) ([]swarm.Secret, error) {
^
cli/command/secret/client_test.go:40:35: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *fakeClient) SecretRemove(ctx context.Context, name string) error {
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
81 lines
2.0 KiB
Go
81 lines
2.0 KiB
Go
package secret
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/cli/internal/test"
|
|
"github.com/pkg/errors"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func TestSecretRemoveErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
args []string
|
|
secretRemoveFunc func(context.Context, string) error
|
|
expectedError string
|
|
}{
|
|
{
|
|
args: []string{},
|
|
expectedError: "requires at least 1 argument.",
|
|
},
|
|
{
|
|
args: []string{"foo"},
|
|
secretRemoveFunc: func(_ context.Context, name string) error {
|
|
return errors.Errorf("error removing secret")
|
|
},
|
|
expectedError: "error removing secret",
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
cmd := newSecretRemoveCommand(
|
|
test.NewFakeCli(&fakeClient{
|
|
secretRemoveFunc: tc.secretRemoveFunc,
|
|
}),
|
|
)
|
|
cmd.SetArgs(tc.args)
|
|
cmd.SetOut(io.Discard)
|
|
assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
}
|
|
}
|
|
|
|
func TestSecretRemoveWithName(t *testing.T) {
|
|
names := []string{"foo", "bar"}
|
|
var removedSecrets []string
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
secretRemoveFunc: func(_ context.Context, name string) error {
|
|
removedSecrets = append(removedSecrets, name)
|
|
return nil
|
|
},
|
|
})
|
|
cmd := newSecretRemoveCommand(cli)
|
|
cmd.SetArgs(names)
|
|
assert.NilError(t, cmd.Execute())
|
|
assert.Check(t, is.DeepEqual(names, strings.Split(strings.TrimSpace(cli.OutBuffer().String()), "\n")))
|
|
assert.Check(t, is.DeepEqual(names, removedSecrets))
|
|
}
|
|
|
|
func TestSecretRemoveContinueAfterError(t *testing.T) {
|
|
names := []string{"foo", "bar"}
|
|
var removedSecrets []string
|
|
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
secretRemoveFunc: func(_ context.Context, name string) error {
|
|
removedSecrets = append(removedSecrets, name)
|
|
if name == "foo" {
|
|
return errors.Errorf("error removing secret: %s", name)
|
|
}
|
|
return nil
|
|
},
|
|
})
|
|
|
|
cmd := newSecretRemoveCommand(cli)
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetArgs(names)
|
|
assert.Error(t, cmd.Execute(), "error removing secret: foo")
|
|
assert.Check(t, is.DeepEqual(names, removedSecrets))
|
|
}
|