p4u1/docker-cli
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
e2707394d002113255b93b05ea55f8380742c8ef
docker-cli/components/engine/integration-cli
History
Yong Tang e2707394d0 Fix issue in docker import -c with quoted flags 
This fix tries to address the issue in 26173 where `docker import -c`
with quoted flags returns an error.

The issue was that in `api/client/image/import.go` the flag
`--change/-c` was handled by `StringSliceVarP` which does not handle
the quote well.

The similiar issue was enountered for 23309 (`docker commit`).

This fix takes the same approach as 23309 where `StringSliceVarP`
was replaced with `VarP` and `opts.ListOpts`.

An integration test has been added to cover the changes.

This fix fixes 26173.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Upstream-commit: a79a27412d721a042ae96b411ab1b5b926a7d28a
Component: engine
2016-09-01 16:28:22 -07:00
..
fixtures
…
benchmark_test.go
…
check_test.go
Merge pull request #25143 from cpuguy83/update_go-check
2016-08-15 22:09:20 -07:00
daemon_swarm_hack.go
Remove unnecessary CmdWithArgs
2016-07-28 20:14:14 -04:00
daemon_swarm.go
Fix retry logic for out of sequence errors
2016-08-16 18:57:01 -07:00
daemon_unix.go
TestDaemonDiscoveryBackendConfigReload behavior
2016-08-26 11:02:04 -04:00
daemon_windows.go
TestDaemonDiscoveryBackendConfigReload behavior
2016-08-26 11:02:04 -04:00
daemon.go
Merge pull request #25890 from cpuguy83/fix_swarm_control_sock_path
2016-08-30 08:51:52 -04:00
docker_api_attach_test.go
Swarm integration tests
2016-06-13 22:16:18 -07:00
docker_api_auth_test.go
Return remote API errors as JSON
2016-06-07 18:45:27 -07:00
docker_api_build_test.go
Windows: Enable 5 Build API tests
2016-08-30 08:41:17 -07:00
docker_api_containers_test.go
Windows: Port api_containers_test tests
2016-08-30 14:15:33 -07:00
docker_api_create_test.go
Return remote API errors as JSON
2016-06-07 18:45:27 -07:00
docker_api_events_test.go
…
docker_api_exec_resize_test.go
Windows: Enable a couple of exec tests
2016-08-30 15:03:18 -07:00
docker_api_exec_test.go
Return remote API errors as JSON
2016-06-07 18:45:27 -07:00
docker_api_images_test.go
…
docker_api_info_test.go
Remove execution driver
2016-07-11 14:52:27 +08:00
docker_api_inspect_test.go
Docker api inspect Assert HostConfig
2016-08-04 23:01:16 +08:00
docker_api_inspect_unix_test.go
…
docker_api_logs_test.go
Return remote API errors as JSON
2016-06-07 18:45:27 -07:00
docker_api_network_test.go
vendor docker/engine-api@f9cef59044
2016-08-31 22:39:13 +02:00
docker_api_resize_test.go
Return remote API errors as JSON
2016-06-07 18:45:27 -07:00
docker_api_service_update_test.go
Change docker service update semantics
2016-06-17 17:09:40 -07:00
docker_api_stats_test.go
Change number of pings to 1
2016-08-03 13:30:34 -07:00
docker_api_stats_unix_test.go
TestApiStatsContainerGetMemoryLimit: Add cgroup memory test
2016-05-04 20:46:41 +02:00
docker_api_swarm_test.go
Fix issue in API POST /services/(id or name)/update
2016-08-29 21:13:53 -07:00
docker_api_test.go
Change to use c.Assert() instead of result.Assert()
2016-08-23 15:12:36 -04:00
docker_api_update_unix_test.go
…
docker_api_version_test.go
…
docker_api_volumes_test.go
…
docker_cli_attach_test.go
Windows: Enable 2 TestAttach* tests
2016-08-29 15:57:27 -07:00
docker_cli_attach_unix_test.go
Create a unified RunCommand function with Assert()
2016-08-23 15:11:46 -04:00
docker_cli_authz_unix_test.go
Fix AuthZ plugins headers change issue
2016-08-23 21:08:23 -07:00
docker_cli_build_test.go
Windows: Enable multiple cli build tests
2016-08-30 09:51:13 -07:00
docker_cli_build_unix_test.go
Create a unified RunCommand function with Assert()
2016-08-23 15:11:46 -04:00
docker_cli_by_digest_test.go
Refactor docker inspect to work on all types
2016-08-25 16:29:08 -07:00
docker_cli_commit_test.go
Windows: Enable some commit tests
2016-08-30 09:48:18 -07:00
docker_cli_config_test.go
…
docker_cli_cp_from_container_test.go
Windows: Enable some cp integration tests
2016-08-30 14:32:10 -07:00
docker_cli_cp_test.go
Windows: Enable some cp integration tests
2016-08-30 14:32:10 -07:00
docker_cli_cp_to_container_test.go
Windows: Enable some cp integration tests
2016-08-30 14:32:10 -07:00
docker_cli_cp_to_container_unix_test.go
…
docker_cli_cp_utils.go
…
docker_cli_create_test.go
Windows: Enable some create CI tests
2016-08-30 14:38:19 -07:00
docker_cli_daemon_experimental_test.go
Add option to specify name without --name in volume create
2016-08-25 14:20:06 -07:00
docker_cli_daemon_test.go
Change related test from DockerSuite to DockerDaemonSuite in docker_cli_daemon_test.go
2016-08-30 18:30:27 -07:00
docker_cli_diff_test.go
Do not create /dev/fuse by default
2016-08-12 12:33:42 +01:00
docker_cli_events_test.go
Change to use c.Assert() instead of result.Assert()
2016-08-23 15:12:36 -04:00
docker_cli_events_unix_test.go
Merge pull request #26020 from tonistiigi/fix-eventsbefore-test
2016-08-30 22:24:52 +02:00
docker_cli_exec_test.go
Windows: Enable a couple of exec tests
2016-08-30 15:03:18 -07:00
docker_cli_exec_unix_test.go
…
docker_cli_experimental_test.go
…
docker_cli_export_import_test.go
…
docker_cli_external_graphdriver_unix_test.go
Ignore 'not a swarm error' when inspecting a task.
2016-08-03 12:22:07 -04:00
docker_cli_external_volume_driver_unix_test.go
Add option to specify name without --name in volume create
2016-08-25 14:20:06 -07:00
docker_cli_health_test.go
Fix exec form of HEALTHCHECK CMD
2016-08-31 17:50:12 +01:00
docker_cli_help_test.go
Windows: Enable TestHelpExitCodesHelpOutput
2016-08-30 15:05:02 -07:00
docker_cli_history_test.go
Windows: Enable docker_cli_history_test
2016-08-30 09:31:33 -07:00
docker_cli_images_test.go
Windows: Enable TestImage and TestImport tests
2016-08-30 15:20:55 -07:00
docker_cli_import_test.go
Fix issue in docker import -c with quoted flags
2016-09-01 16:28:22 -07:00
docker_cli_info_test.go
Revert "Change related tests from DockerSuite to DockerDaemonSuite in docker_cli_info_test.go"
2016-08-31 11:52:22 -07:00
docker_cli_info_unix_test.go
Add security info to docker info
2016-06-14 12:23:45 -07:00
docker_cli_inspect_test.go
Windows: Enable multiple TestInspect tests
2016-08-31 08:12:50 -07:00
docker_cli_kill_test.go
…
docker_cli_links_test.go
Remove unnecessary json.Unmarshal wrapper.
2016-08-23 15:11:46 -04:00
docker_cli_links_unix_test.go
…
docker_cli_login_test.go
…
docker_cli_logout_test.go
…
docker_cli_logs_bench_test.go
…
docker_cli_logs_test.go
Add support for reading logs extra attrs
2016-05-06 20:42:20 -04:00
docker_cli_nat_test.go
…
docker_cli_netmode_test.go
fix typos
2016-06-02 17:17:22 +08:00
docker_cli_network_unix_test.go
Fix issue in --ip6 validation for docker create
2016-08-30 19:28:44 -07:00
docker_cli_oom_killed_test.go
Add the swapMemorySupport requirement to OOM tests
2016-05-10 11:28:00 -07:00
docker_cli_pause_test.go
Get events until a time in the past.
2016-04-14 16:22:16 -07:00
docker_cli_plugins_test.go
add -f to plugin inspect
2016-08-25 22:40:05 -07:00
docker_cli_port_test.go
…
docker_cli_proxy_test.go
…
docker_cli_ps_test.go
Add option to specify name without --name in volume create
2016-08-25 14:20:06 -07:00
docker_cli_pull_local_test.go
fixed spelling error in cli pull local test
2016-05-19 17:52:42 -05:00
docker_cli_pull_test.go
Move implicit pull test to use local registry
2016-05-02 18:14:13 -07:00
docker_cli_pull_trusted_test.go
…
docker_cli_push_test.go
add defer file.Close to avoid potential fd leak
2016-08-10 08:36:09 +08:00
docker_cli_registry_user_agent_test.go
modify func namt from TestUserAgentPassThroughOnPull to TestUserAgentPassThrough
2016-08-08 11:40:20 +08:00
docker_cli_rename_test.go
Refactor docker inspect to work on all types
2016-08-25 16:29:08 -07:00
docker_cli_restart_test.go
Fix typo
2016-08-09 09:42:23 +08:00
docker_cli_rm_test.go
…
docker_cli_rmi_test.go
update "image delete" error to match actual behavior
2016-07-18 23:17:55 +02:00
docker_cli_run_test.go
Merge pull request #23830 from ardnaxelarak/23345_remove_name_from_volume_create
2016-08-26 21:52:07 +02:00
docker_cli_run_unix_test.go
Remove gccgo support
2016-08-24 11:09:35 +01:00
docker_cli_save_load_test.go
add defer file.Close to avoid potential fd leak
2016-08-10 08:36:09 +08:00
docker_cli_save_load_unix_test.go
add defer file.Close to avoid potential fd leak
2016-08-10 08:36:09 +08:00
docker_cli_search_test.go
Use spf13/cobra for docker search
2016-06-03 19:50:01 +02:00
docker_cli_service_create_test.go
Remove hack from test name.
2016-07-28 20:12:36 -04:00
docker_cli_service_health_test.go
extend health check to start service
2016-07-25 15:49:22 -07:00
docker_cli_service_update_test.go
Remove unnecessary CmdWithArgs
2016-07-28 20:14:14 -04:00
docker_cli_sni_test.go
…
docker_cli_stack_test.go
Remove unnecessary CmdWithArgs
2016-07-28 20:14:14 -04:00
docker_cli_start_test.go
Using waitExitOrRemoved for docker start
2016-08-26 00:16:49 +08:00
docker_cli_stats_test.go
Do not remove containers from stats list on err
2016-04-13 16:36:34 -04:00
docker_cli_stop_test.go
Add test case for stopping a restarting container
2016-04-10 15:39:28 +08:00
docker_cli_swarm_test.go
vendor docker/engine-api@f9cef59044
2016-08-31 22:39:13 +02:00
docker_cli_tag_test.go
Remove deprecated -f flag on docker tag
2016-06-01 09:44:25 -07:00
docker_cli_top_test.go
…
docker_cli_update_test.go
Forbid update restart policy of container with AutoRemove flag
2016-08-16 15:36:13 +08:00
docker_cli_update_unix_test.go
Fix update memory without memoryswap
2016-08-08 18:36:03 +08:00
docker_cli_userns_test.go
Ignore 'not a swarm error' when inspecting a task.
2016-08-03 12:22:07 -04:00
docker_cli_v2_only_test.go
…
docker_cli_version_test.go
…
docker_cli_volume_test.go
Add option to specify name without --name in volume create
2016-08-25 14:20:06 -07:00
docker_cli_wait_test.go
…
docker_deprecated_api_v124_test.go
remove deprecated feature of passing HostConfig at API container start
2016-06-01 22:25:17 +08:00
docker_deprecated_api_v124_unix_test.go
remove deprecated feature of passing HostConfig at API container start
2016-06-01 22:25:17 +08:00
docker_experimental_network_test.go
Change to use c.Assert() instead of result.Assert()
2016-08-23 15:12:36 -04:00
docker_hub_pull_suite_test.go
Remove unnecessary CmdWithArgs
2016-07-28 20:14:14 -04:00
docker_test_vars.go
It is better to add "\n" in printf
2016-08-23 09:01:25 +08:00
docker_utils.go
The first letter should be small in errors.New
2016-09-01 11:26:40 +08:00
events_utils.go
Fix incorrect usage of logrus when formatting string is present
2016-06-11 15:37:36 -07:00
npipe_windows.go
…
npipe.go
…
registry_mock.go
…
registry.go
add defer file.Close to avoid potential fd leak
2016-08-10 08:36:09 +08:00
requirements_unix.go
TestRunSeccompUnconfinedCloneUserns: Check for unprivileged_userns_clone
2016-07-29 12:16:03 -04:00
requirements.go
Remove gccgo support
2016-08-24 11:09:35 +01:00
test_vars_exec.go
…
test_vars_noexec.go
…
test_vars_noseccomp.go
…
test_vars_seccomp.go
…
test_vars_unix.go
…
test_vars_windows.go
…
trust_server.go
add defer file.Close to avoid potential fd leak
2016-08-10 08:36:09 +08:00
utils.go
Create a unified RunCommand function with Assert()
2016-08-23 15:11:46 -04:00