Due to the CL https://go-review.googlesource.com/c/39608/ in x/sys/windows which changed the definitions of STD_INPUT_HANDLE, STD_OUTPUT_HANDLE and STD_ERROR_HANDLE, we get the following failure after re-vendoring x/sys/windows: 07:47:01 # github.com/docker/docker/pkg/term 07:47:01 pkg/term/term_windows.go:82: constant 4294967286 overflows int 07:47:01 pkg/term/term_windows.go:88: constant 4294967285 overflows int 07:47:01 pkg/term/term_windows.go:94: constant 4294967284 overflows int 07:47:12 Build step 'Execute shell' marked build as failure Temporarily switch back pkg/term to use these constants from the syscall package and add a comment about it. To really fix this, go-ansiterm should probably be switched to use x/sys/windows. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Upstream-commit: ef5252fc5dcd83d1b8dfe173a68691c8a63e7e4a Component: engine
pkg/ is a collection of utility packages used by the Docker project without being specific to its internals.
Utility packages are kept separate from the docker core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Docker organization, to facilitate re-use by other projects. However that is not the priority.
The directory pkg is named after the same directory in the camlistore project. Since Brad is a core
Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!
Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!