add headers to embed nextcloud in frame on external site

This introduces new env variables to configure nextloud to be embedded via
iframe on an external site.
Setting X_FRAME_OPTIONS_ENABLED=1 will configure nginx and nextcloud to
set X-Frame-Options and CSP headers to allow the domain configured in
X_FRAME_OPTIONS_ALLOW_FROM.

.drone.yml

@@ -3,7 +3,7 @@ kind: pipeline
 name: deploy to swarm-test.autonomic.zone
 steps:
   - name: deployment
-    image: git.coopcloud.tech/coop-cloud/stack-ssh-deploy:latest
+    image: decentral1se/stack-ssh-deploy:latest
     settings:
       host: swarm-test.autonomic.zone
       stack: nextcloud
@@ -11,22 +11,14 @@ steps:
       purge: true
       deploy_key:
         from_secret: drone_ssh_swarm_test
-      networks:
-        - proxy
     environment:
       DOMAIN: nextcloud.swarm-test.autonomic.zone
       STACK_NAME: nextcloud
       LETS_ENCRYPT_ENV: production
       ADMIN_USER: foobar
-      FPM_TUNE_VERSION: v1
-      NGINX_CONF_VERSION: v1
-      MY_CNF_VERSION: v1
-      ENTRYPOINT_VERSION: v1
       SECRET_DB_PASSWORD_VERSION: v1
       SECRET_DB_ROOT_PASSWORD_VERSION: v1
       SECRET_ADMIN_PASSWORD_VERSION: v1
-      SECRET_ONLYOFFICE_JWT_VERSION: v1
-      SECRET_BBB_SECRET_VERSION: v1
       EXTRA_VOLUME: "/dev/null:/tmp/.dummy"
 trigger:
   branch:

.env.sample

@@ -17,37 +17,5 @@ SECRET_ADMIN_PASSWORD_VERSION=v1
 
 EXTRA_VOLUME=/dev/null:/tmp/.dummy
 
-# fpm-tune, see: https://spot13.com/pmcalculator/
-FPM_MAX_CHILDREN=131
-FPM_START_SERVERS=32
-FPM_MIN_SPARE_SERVERS=32
-FPM_MAX_SPARE_SERVERS=98
-
-DEFAULT_QUOTA="10 GB"
-
 # X_FRAME_OPTIONS_ENABLED=1
 # X_FRAME_OPTIONS_ALLOW_FROM=embedding-site.example.org
-
-# COMPOSE_FILE="$COMPOSE_FILE:compose.smtp.yml"
-# See https://github.com/nextcloud/docker#auto-configuration-via-environment-variables for default values
-# SMTP_AUTHTYPE=
-# SMTP_HOST=
-# SMTP_SECURE=
-# SMTP_NAME=
-# SMTP_PORT=
-# MAIL_FROM_ADDRESS=
-# MAIL_DOMAIN=
-# SECRET_SMTP_PASSWORD_VERSION=v1
-
-# COMPOSE_FILE="$COMPOSE_FILE:compose.apps.yml"
-# APPS="calendar sociallogin onlyoffice"
-#
-# ONLYOFFICE_URL=https://onlyoffice.example.com
-# SECRET_ONLYOFFICE_JWT_VERSION=v1
-#
-# BBB_URL=https://talk.example.org/bigbluebutton/ # trailing slash!
-# SECRET_BBB_SECRET_VERSION=v1
-#
-# OCC_CMDS="app:disable dashboard"
-# OCC_CMDS="$OCC_CMDS|config:app:set sociallogin auto_create_groups --value 1"
-# OCC_CMDS="$OCC_CMDS|config:app:set sociallogin hide_default_login --value 1"

README.md

@@ -21,9 +21,9 @@ Fully automated luxury Nextcloud via docker-swarm.
 2. Deploy [`coop-cloud/traefik`]
 3. `abra app new nextcloud --secrets` (optionally with `--pass` if you'd like
    to save secrets in `pass`)
-4. `abra app config YOURAPPDOMAIN` - be sure to change `$DOMAIN` to something that resolves to
+4. `abra app YOURAPPDOMAIN config` - be sure to change `$DOMAIN` to something that resolves to
    your Docker swarm box
-5. `abra app deploy YOURAPPDOMAIN`
+5. `abra app YOURAPPDOMAIN deploy`
 
 ## How do I customise the default home page when logging in?
 
@@ -33,11 +33,11 @@ Fully automated luxury Nextcloud via docker-swarm.
 
 ## Running `occ`
 
-`abra app run --user www-data YOURAPPDOMAIN app php occ user:list --help`
+`abra app run --user www-data YOURAPPDOMAIN app occ user:list --help`
 
 ## Upgrading Nextcloud apps
 
-`abra app run --user www-data YOURAPPDOMAIN app php occ app:update --all`
+`abra app run --user www-data YOURAPPDOMAIN app occ app:update --all`
 
 ## How do I fix a Nextcloud version snafu?
 

abra.sh

@@ -1,54 +1,106 @@
-#!/bin/bash
+export FPM_TUNE_VERSION=v4
-
+export NGINX_CONF_VERSION=v3
-export FPM_TUNE_VERSION=v5
-export NGINX_CONF_VERSION=v4
 export MY_CNF_VERSION=v4
-export ENTRYPOINT_VERSION=v3
+export ENTRYPOINT_VERSION=v1
 
-run_occ(){
+NC_APP_DIR="app:/var/www/html"
-    su -p www-data -s /bin/sh -c "/var/www/html/occ $@"
+
+sub_occ(){
+  # shellcheck disable=SC2034
+  abra__service_="app"
+  # shellcheck disable=SC2034
+  abra___user="www-data"
+  sub_app_run php /var/www/html/occ "$@"
 }
 
-post_install_occ(){
+_backup_app() {
-    IFS='|' read -ra CMD <<< "$OCC_CMDS"
+  # Copied _abra_backup_dir to make UX better on restore and backup
-    for cmd in "${CMD[@]}"; do
+  {
-      run_occ "$cmd"
+    abra__src_="$1"
-    done
+    abra__dst_="-"
+  }
+
+  # shellcheck disable=SC2154
+  FILENAME="$(basename "$1").tar"
+
+  debug "Copying '$1' to '$FILENAME'"
+
+  silence
+  mkdir -p /tmp/abra
+  sub_app_cp > /tmp/abra/$FILENAME
+  unsilence
 }
 
-install_apps(){
+next_maintenance_on() {
-    install_apps="$@"
+  silence
-    if [ -z "$install_apps" ]
+  sub_occ maintenance:mode --on > /dev/null
-    then
+  unsilence
-        install_apps=$APPS
+  debug "Nextcloud maintenance mode enabled"
-    fi
-    for app in $install_apps
-    do
-        run_occ "app:install $app"
-    done
 }
 
-set_app_config(){
+next_maintenance_off() {
-    APP=$1
+  silence
-    KEY=$2
+  sub_occ maintenance:mode --off > /dev/null
-    VALUE=$3
+  unsilence
-    run_occ "config:app:set $APP $KEY --value $VALUE"
+  debug "Nextcloud maintenance mode disabled"
 }
 
-install_bbb(){
+abra_backup_app() {
-    install_apps bbb
+  # shellcheck disable=SC2154
-    set_app_config bbb app.navigation true
+  ARK_FILENAME="$ABRA_BACKUP_DIR/${abra__app_}_app_$(date +%F).tar.gz"
-    set_app_config bbb api.url "$BBB_URL"
+  # Cant be FILENAME as that gets changed by something
-    set_app_config bbb api.secret "$(cat /run/secrets/bbb_secret)"
+  next_maintenance_on
+  _backup_app $NC_APP_DIR/config
+  _backup_app $NC_APP_DIR/data
+  _backup_app $NC_APP_DIR/themes
+  # Combine archives
+  tar -Af /tmp/abra/config.tar /tmp/abra/data.tar
+  tar -Af /tmp/abra/config.tar /tmp/abra/themes.tar
+  gzip /tmp/abra/config.tar -c > "$ARK_FILENAME"
+  rm /tmp/abra/*.tar
+  success "Backed up 'app' to $ARK_FILENAME"
+  next_maintenance_off
 }
 
-install_onlyoffice(){
+abra_backup_db() {
-    install_apps onlyoffice
+  next_maintenance_on
-    set_app_config onlyoffice DocumentServerUrl "$ONLYOFFICE_URL"
+  _abra_backup_mysql "db" "nextcloud"
-    set_app_config onlyoffice jwt_secret "$(cat /run/secrets/onlyoffice_jwt)"
+  next_maintenance_off
-    set_app_config onlyoffice customizationForcesave true
 }
 
-set_default_quota(){
+abra_backup() {
-    set_app_config files default_quota '"$DEFAULT_QUOTA"'
+  abra_backup_app && abra_backup_db
 }
+
+
+abra_restore_app() {
+  next_maintenance_on
+  # shellcheck disable=SC2034
+  {
+  abra__src_="-"
+  abra__dst_=$NC_APP_DIR
+  }
+
+  zcat "$@" | sub_app_cp
+
+  next_maintenance_off
+  sub_occ files:scan --all > /dev/null # Needs to be run in normal mode
+  success "Restored 'app'"
+}
+
+# abra_restore_db() {
+#   warning "Restoring the database is on a existing app and not a new one has not been tested. Use with caution."
+#   next_maintenance_on
+#   # 3wc: unlike abra_backup_db, we can assume abra__service_ will be 'db' if we
+#   # got this far..
+
+#   # shellcheck disable=SC2034
+#   abra___no_tty="true"
+
+#   DB_PASSWORD=$(sub_app_run cat /run/secrets/db_password)
+
+#   zcat "$@" | sub_app_run mysql -u root -p"$DB_PASSWORD" wordpress
+
+#   success "Restored 'db'"
+#   next_maintenance_off
+# }

compose.apps.yml

@@ -1,18 +0,0 @@
-version: "3.8"
-services:
-  app:
-    secrets:
-      - onlyoffice_jwt
-      - bbb_secret
-    environment:
-      - APPS
-      - ONLYOFFICE_URL
-      - BBB_URL
-
-secrets:
-  onlyoffice_jwt:
-    external: true
-    name: ${STACK_NAME}_onlyoffice_jwt_${SECRET_ONLYOFFICE_JWT_VERSION}
-  bbb_secret:
-    external: true
-    name: ${STACK_NAME}_bbb_secret_${SECRET_BBB_SECRET_VERSION}

compose.mariadb.yml

@@ -31,12 +31,6 @@ services:
           backupbot.backup.pre-hook: 'mkdir -p /tmp/backup/ && mysqldump --single-transaction -u root -p"$$(cat /run/secrets/db_root_password)" nextcloud > /tmp/backup/backup.sql'
           backupbot.backup.post-hook: "rm -rf /tmp/backup"
           backupbot.backup.path: "/tmp/backup/"
-    healthcheck:
-      test: ["CMD-SHELL", 'mysqladmin -p"$$(cat /run/secrets/db_root_password)"  ping']
-      interval: 30s
-      timeout: 10s
-      retries: 10
-      start_period: 1m
 configs:
   my_tune:
     name: ${STACK_NAME}_my_cnf_${MY_CNF_VERSION}

compose.postgres.yml

@@ -2,6 +2,7 @@ version: '3.8'
 
 services:
   app:
+    entrypoint: "sh -c 'sleep 10 && /entrypoint.sh php-fpm'" # tries to mitigate this error with postgres https://github.com/nextcloud/docker/issues/1204
     environment:
       - POSTGRES_HOST=db
       - POSTGRES_DB=nextcloud

compose.smtp.yml

@@ -1,19 +0,0 @@
-version: "3.8"
-services:
-  app:
-    secrets:
-      - smtp_password
-    environment:
-      - SMTP_AUTHTYPE
-      - SMTP_HOST
-      - SMTP_SECURE
-      - SMTP_NAME
-      - SMTP_PORT
-      - SMTP_PASSWORD_FILE=/run/secrets/smtp_password
-      - MAIL_FROM_ADDRESS
-      - MAIL_DOMAIN
-
-secrets:
-  smtp_password:
-    external: true
-    name: ${STACK_NAME}_smtp_password_${SECRET_SMTP_PASSWORD_VERSION}

compose.yml

@@ -1,7 +1,7 @@
 version: "3.8"
 services:
   web:
-    image: nginx:1.23.3
+    image: nginx:1.23.1
     configs:
       - source: nginx_conf
         target: /etc/nginx/nginx.conf
@@ -33,15 +33,9 @@ services:
         - "traefik.http.routers.${STACK_NAME}.middlewares=${STACK_NAME}-redirect"
         - "traefik.http.middlewares.${STACK_NAME}-redirect.headers.SSLForceHost=true"
         - "traefik.http.middlewares.${STACK_NAME}-redirect.headers.SSLHost=${DOMAIN}"
-    healthcheck:
-      test: ["CMD-SHELL", 'curl -s -N curl -Ns localhost/status.php |  grep "installed\":true"']
-      interval: 30s
-      timeout: 10s
-      retries: 10
-      start_period: 5m
 
   app:
-    image: nextcloud:25.0.4-fpm
+    image: nextcloud:24.0.3-fpm
     depends_on:
       - db
     configs:
@@ -55,8 +49,6 @@ services:
       - db_password
       - admin_password
     environment:
-      - APPS
-      - OCC_CMDS
       - X_FRAME_OPTIONS_ALLOW_FROM
       - X_FRAME_OPTIONS_ENABLED
       - DOMAIN
@@ -66,13 +58,12 @@ services:
       - NEXTCLOUD_TRUSTED_DOMAINS=${DOMAIN}
       - TRUSTED_PROXIES=traefik
       - REDIS_HOST=cache
+      - SMTP_HOST
+      - MAIL_FROM_ADDRESS
+      - MAIL_DOMAIN
+      - SMTP_AUTHTYPE=PLAIN
       - OVERWRITEPROTOCOL=https
       - PHP_MEMORY_LIMIT=1G
-      - FPM_MAX_CHILDREN=131
-      - FPM_START_SERVERS=32
-      - FPM_MIN_SPARE_SERVERS=32
-      - FPM_MAX_SPARE_SERVERS=98
-      - DEFAULT_QUOTA
     volumes:
       - nextcloud:/var/www/html/
       - nextapps:/var/www/html/custom_apps:cached
@@ -86,18 +77,12 @@ services:
         failure_action: rollback
         order: start-first
       labels:
-        - "coop-cloud.${STACK_NAME}.version=3.1.2+25.0.4-fpm"
+        - "coop-cloud.${STACK_NAME}.version=2.1.2+24.0.3-fpm"
         - "backupbot.backup=true"
         - "backupbot.backup.path=/var/www/html/config/,/var/www/html/data/,/var/www/html/custom_apps/"
-    healthcheck:
-      test: ["CMD-SHELL", 'SCRIPT_NAME=status SCRIPT_FILENAME=/var/www/html/status.php REQUEST_METHOD=GET cgi-fcgi -bind -connect 127.0.0.1:9000 | grep "installed\":true"']
-      interval: 30s
-      timeout: 10s
-      retries: 10
-      start_period: 5m
 
   cron:
-    image: nextcloud:25.0.4-fpm
+    image: nextcloud:24.0.3-fpm
     volumes:
       - nextcloud:/var/www/html/
       - nextapps:/var/www/html/custom_apps:cached
@@ -109,16 +94,11 @@ services:
     entrypoint: /cron.sh
 
   cache:
-    image: redis:7.0.9-alpine
+    image: redis:7.0.4-alpine
     networks:
       - internal
     volumes:
       - "redis:/data"
-    healthcheck:
-      test: ["CMD", "redis-cli", "ping"]
-      interval: 3s
-      timeout: 5s
-      retries: 20
 
 secrets:
   db_root_password:
@@ -126,7 +106,7 @@ secrets:
     name: ${STACK_NAME}_db_root_password_${SECRET_DB_ROOT_PASSWORD_VERSION}
   db_password:
     external: true
-    name: ${STACK_NAME}_db_password_${SECRET_DB_PASSWORD_VERSION}
+    name: ${STACK_NAME}_db_password_${SECRET_DB_ROOT_PASSWORD_VERSION}
   admin_password:
     external: true
     name: ${STACK_NAME}_admin_password_${SECRET_ADMIN_PASSWORD_VERSION}
@@ -147,7 +127,6 @@ configs:
   fpm_tune:
     name: ${STACK_NAME}_fpm_tune_${FPM_TUNE_VERSION}
     file: fpm-tune.ini
-    template_driver: golang
   entrypoint:
     name: ${STACK_NAME}_entrypoint_${ENTRYPOINT_VERSION}
     file: entrypoint.sh.tmpl

entrypoint.sh.tmpl

@@ -1,41 +1,9 @@
 #!/bin/bash
 
-set -eu
-
-file_env() {
-  local var="$1"
-  local fileVar="${var}_FILE"
-  local def="${2:-}"
-
-  if [ "${!var:-}" ] && [ "${!fileVar:-}" ]; then
-    echo >&2 "error: both $var and $fileVar are set (but are exclusive)"
-    exit 1
-  fi
-
-  local val="$def"
-  if [ "${!var:-}" ]; then
-    val="${!var}"
-  elif [ "${!fileVar:-}" ]; then
-    val="$(< "${!fileVar}")"
-  fi
-
-  export "$var"="$val"
-  unset "$fileVar"
-}
-
-file_env "SMTP_PASSWORD"
-
-echo "Giving the db container some time to come up"; sleep 20
-# see this issue with postgres db https://github.com/nextcloud/docker/issues/1204
-
 {{ if eq (env "X_FRAME_OPTIONS_ENABLED") "1" }}
 if ! [[ $(grep {{ env "X_FRAME_OPTIONS_ALLOW_FROM" }} lib/public/AppFramework/Http/ContentSecurityPolicy.php) ]]; then
     sed -i "91 a\\\t\t'{{ env "X_FRAME_OPTIONS_ALLOW_FROM" }}', " lib/public/AppFramework/Http/ContentSecurityPolicy.php
 fi
 {{ end }}
 
-# Required for healthcheck
-which cgi-fcgi > /dev/null || (apt-get update && apt-get install -y libfcgi-bin)
-
-
 /entrypoint.sh php-fpm

fpm-tune.ini

@@ -1,5 +1,5 @@
 pm = dynamic
-pm.max_children = {{ env "FPM_MAX_CHILDREN" }}
+pm.max_children = 131
-pm.start_servers = {{ env "FPM_START_SERVERS" }}
+pm.start_servers = 32
-pm.min_spare_servers = {{ env "FPM_MIN_SPARE_SERVERS" }}
+pm.min_spare_servers = 32
-pm.max_spare_servers = {{ env "FPM_MAX_SPARE_SERVERS" }}
+pm.max_spare_servers = 98

nginx.conf.tmpl

@@ -67,7 +67,8 @@ http {
         add_header X-XSS-Protection                     "1; mode=block" always;
 
         {{ if eq (env "X_FRAME_OPTIONS_ENABLED") "1" }}
-        add_header Content-Security-Policy              "frame-ancestors {{ env "X_FRAME_OPTIONS_ALLOW_FROM" }} {{ env "DOMAIN" }}";
+        add_header X-Frame-Options                      "{{ env "X_FRAME_OPTIONS_ALLOW_FROM" }}"    always;
+        add_header Content-Security-Policy              "frame-ancestors {{ env "X_FRAME_OPTIONS_ALLOW_FROM" }}";
         {{ else }}
         add_header X-Frame-Options                      "SAMEORIGIN"    always;
         {{ end }}

releases/3.1.0+25.0.1-fpm

@@ -1,57 +0,0 @@
-
-## FPM Tune
-
-The fpm-tune.ini settings are now configurable by `.env`. Please add this to your servers configs:
-
-```
-# fpm-tune, see: https://spot13.com/pmcalculator/
-FPM_MAX_CHILDREN=131
-FPM_START_SERVERS=32
-FPM_MIN_SPARE_SERVERS=32
-FPM_MAX_SPARE_SERVERS=98
-```
-
-## SMTP
-
-Add SMTP Config to your .env file:
-
-```
-# COMPOSE_FILE="$COMPOSE_FILE:compose.smtp.yml"
-# See https://github.com/nextcloud/docker#auto-configuration-via-environment-variables for default values
-# SMTP_AUTHTYPE=
-# SMTP_HOST=
-# SMTP_SECURE=
-# SMTP_NAME=
-# SMTP_PORT=
-# MAIL_FROM_ADDRESS=
-# MAIL_DOMAIN=
-# SECRET_SMTP_PASSWORD_VERSION=v1
-abra app secret insert example.com smtp_password v1 example_password
-```
-
-
-## Post Deploy Commands
-
-Some Apps can also be managed with abra app cmd!
-
-```
-# COMPOSE_FILE="$COMPOSE_FILE:compose.apps.yml"
-# APPS="calendar sociallogin onlyoffice"
-abra app cmd example.com app install_apps
-# ONLYOFFICE_URL=https://onlyoffice.example.com
-# SECRET_ONLYOFFICE_JWT_VERSION=v1
-abra app secret insert example.com onlyoffice_jwt v1 example_password
-abra app cmd example.com app install_onlyoffice
-# BBB_URL=https://talk.example.org/bigbluebutton/ # trailing slash!
-# SECRET_BBB_SECRET_VERSION=v1
-abra app secret insert example.com bbb_secret v1 example_password
-abra app cmd example.com app install_bbb
-```
-
-## Set Quota
-
-```
-# DEFAULT_QUOTA="10 GB"
-abra app cmd example.com app set_default_quota
-```
-