feat: app rm - check if the app is undeployed before removing

cli/app/remove.go

@@ -65,6 +65,16 @@ var appRemoveCommand = &cli.Command{
 		if err != nil {
 			logrus.Fatal(err)
 		}
+		if !internal.Force {
+			// get app status and check if it's deployed
+			statuses, err := config.GetAppStatuses(appFiles)
+			if err != nil {
+				logrus.Fatal(err)
+			}
+			if statuses[appName] == "deployed" {
+				return errors.New("app still deployed. Run abra app undeploy first. (or pass --force)")
+			}
+		}
 
 		fs := filters.NewArgs()
 		fs.Add("name", appName)
@@ -74,7 +84,6 @@ var appRemoveCommand = &cli.Command{
 		}
 
 		secrets := make(map[string]string)
-		if len(secrets) > 0 {
 		var secretNames []string
 
 		for _, cont := range secretList {
@@ -82,6 +91,7 @@ var appRemoveCommand = &cli.Command{
 			secretNames = append(secretNames, cont.Spec.Annotations.Name)
 		}
 
+		if len(secrets) > 0 {
 			var secretNamesToRemove []string
 			if !internal.Force {
 				secretsPrompt := &survey.MultiSelect{
@@ -112,11 +122,11 @@ var appRemoveCommand = &cli.Command{
 		}
 
 		var vols []string
-		if len(vols) > 0 {
 		for _, vol := range volumeList {
 			vols = append(vols, vol.Name)
 		}
 
+		if len(vols) > 0 {
 			if Volumes {
 				var removeVols []string
 				if !internal.Force {