refactor: persistent DebugFlag

cli/app/backup.go

@@ -39,7 +39,6 @@ var appBackupListCommand = cli.Command{
 	Name:    "list",
 	Aliases: []string{"ls"},
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		snapshotFlag,
 		includePathFlag,
@@ -87,7 +86,6 @@ var appBackupDownloadCommand = cli.Command{
 	Name:    "download",
 	Aliases: []string{"d"},
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		snapshotFlag,
 		includePathFlag,
@@ -159,7 +157,6 @@ var appBackupCreateCommand = cli.Command{
 	Name:    "create",
 	Aliases: []string{"c"},
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		resticRepoFlag,
 	},
@@ -218,7 +215,6 @@ var appBackupSnapshotsCommand = cli.Command{
 	Name:    "snapshots",
 	Aliases: []string{"s"},
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		snapshotFlag,
 	},

cli/app/check.go

@@ -29,7 +29,6 @@ recipes regardless of commenting or not (e.g. through the use of
 ${FOO:<default>} syntax). "check" does not confirm or deny this for you.`,
 	ArgsUsage: "<domain>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.ChaosFlag,
 		internal.OfflineFlag,
 	},

cli/app/cmd.go

@@ -37,7 +37,6 @@ EXAMPLE:
   abra app cmd --local example.com app create_user -- me@example.com`,
 	ArgsUsage: "<domain> [<service>] <command> [-- <args>]",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.LocalCmdFlag,
 		internal.RemoteUserFlag,
 		internal.TtyFlag,
@@ -205,7 +204,6 @@ var appCmdListCommand = cli.Command{
 	Usage:     "List all available commands",
 	ArgsUsage: "<domain>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		internal.ChaosFlag,
 	},

cli/app/config.go

@@ -15,13 +15,10 @@ import (
 )
 
 var appConfigCommand = cli.Command{
-	Name:      "config",
+	Name:                  "config",
-	Aliases:   []string{"cfg"},
+	Aliases:               []string{"cfg"},
-	Usage:     "Edit app config",
+	Usage:                 "Edit app config",
-	ArgsUsage: "<domain>",
+	ArgsUsage:             "<domain>",
-	Flags: []cli.Flag{
-		internal.DebugFlag,
-	},
 	Before:                internal.SubCommandBefore,
 	EnableShellCompletion: true,
 	ShellComplete:         autocomplete.AppNameComplete,

cli/app/cp.go

@@ -30,7 +30,6 @@ var appCpCommand = cli.Command{
 	Aliases:   []string{"c"},
 	ArgsUsage: "<domain> <src> <dst>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 	},
 	Before: internal.SubCommandBefore,

cli/app/deploy.go

@@ -24,7 +24,6 @@ var appDeployCommand = cli.Command{
 	Usage:     "Deploy an app",
 	ArgsUsage: "<domain> [<version>]",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.ForceFlag,
 		internal.ChaosFlag,

cli/app/list.go

@@ -82,7 +82,6 @@ By passing the "--status/-S" flag, you can query all your servers for the
 actual live deployment status. Depending on how many servers you manage, this
 can take some time.`,
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.MachineReadableFlag,
 		statusFlag,
 		listAppServerFlag,

cli/app/logs.go

@@ -30,7 +30,6 @@ var appLogsCommand = cli.Command{
 	Flags: []cli.Flag{
 		internal.StdErrOnlyFlag,
 		internal.SinceLogsFlag,
-		internal.DebugFlag,
 	},
 	Before:                internal.SubCommandBefore,
 	EnableShellCompletion: true,

cli/app/new.go

@@ -44,7 +44,6 @@ var appNewCommand = cli.Command{
 	Usage:       "Create a new app",
 	Description: appNewDescription,
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.NewAppServerFlag,
 		internal.DomainFlag,

cli/app/ps.go

@@ -28,7 +28,6 @@ var appPsCommand = cli.Command{
 	Description: "Show status of a deployed app.",
 	Flags: []cli.Flag{
 		internal.MachineReadableFlag,
-		internal.DebugFlag,
 	},
 	Before:                internal.SubCommandBefore,
 	EnableShellCompletion: true,

cli/app/remove.go

@@ -39,7 +39,6 @@ To delete everything without prompt, use the "--force/-f" or the "--no-input/n"
 flag.`,
 	Flags: []cli.Flag{
 		internal.ForceFlag,
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.OfflineFlag,
 	},

cli/app/restart.go

@@ -21,7 +21,6 @@ var appRestartCommand = cli.Command{
 	Usage:     "Restart an app",
 	ArgsUsage: "<domain> [<service>]",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		internal.AllServicesFlag,
 	},

cli/app/restore.go

@@ -25,7 +25,6 @@ var appRestoreCommand = cli.Command{
 	Usage:     "Restore an app backup",
 	ArgsUsage: "<domain> <service>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		targetPathFlag,
 	},

cli/app/rollback.go

@@ -24,7 +24,6 @@ var appRollbackCommand = cli.Command{
 	Usage:     "Roll an app back to a previous version",
 	ArgsUsage: "<domain> [<version>]",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.ForceFlag,
 		internal.NoDomainChecksFlag,

cli/app/run.go

@@ -36,7 +36,6 @@ var appRunCommand = cli.Command{
 	Name:    "run",
 	Aliases: []string{"r"},
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		noTTYFlag,
 		userFlag,
 	},

cli/app/secret.go

@@ -46,7 +46,6 @@ var appSecretGenerateCommand = cli.Command{
 	Usage:     "Generate secrets",
 	ArgsUsage: "<domain> <secret> <version>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		allSecretsFlag,
 		internal.PassFlag,
 		internal.MachineReadableFlag,

cli/app/services.go

@@ -17,13 +17,10 @@ import (
 )
 
 var appServicesCommand = cli.Command{
-	Name:      "services",
+	Name:                  "services",
-	Aliases:   []string{"sr"},
+	Aliases:               []string{"sr"},
-	Usage:     "Display all services of an app",
+	Usage:                 "Display all services of an app",
-	ArgsUsage: "<domain>",
+	ArgsUsage:             "<domain>",
-	Flags: []cli.Flag{
-		internal.DebugFlag,
-	},
 	Before:                internal.SubCommandBefore,
 	EnableShellCompletion: true,
 	ShellComplete:         autocomplete.AppNameComplete,

cli/app/undeploy.go

@@ -66,7 +66,6 @@ var appUndeployCommand = cli.Command{
 	Aliases:   []string{"un"},
 	ArgsUsage: "<domain>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		pruneFlag,
 	},

cli/app/upgrade.go

@@ -23,7 +23,6 @@ var appUpgradeCommand = cli.Command{
 	Usage:     "Upgrade an app",
 	ArgsUsage: "<domain> [<version>]",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.ForceFlag,
 		internal.NoDomainChecksFlag,

cli/app/volume.go

@@ -18,7 +18,6 @@ var appVolumeListCommand = cli.Command{
 	Aliases:   []string{"ls"},
 	ArgsUsage: "<domain>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 	},
 	Before:                internal.SubCommandBefore,

cli/catalogue/catalogue.go

@@ -24,7 +24,6 @@ var catalogueGenerateCommand = cli.Command{
 	Aliases: []string{"g"},
 	Usage:   "Generate the recipe catalogue",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.PublishFlag,
 		internal.DryFlag,

cli/cli.go

@@ -36,9 +36,6 @@ EXAMPLE:
 
     abra autocomplete bash`,
 	ArgsUsage: "<shell>",
-	Flags: []cli.Flag{
-		internal.DebugFlag,
-	},
 	Action: func(ctx context.Context, cmd *cli.Command) error {
 		shellType := cmd.Args().First()
 
@@ -157,6 +154,9 @@ func newAbraApp(version, commit string) *cli.Command {
                          |_|
 `,
 		Version: fmt.Sprintf("%s-%s", version, commit[:7]),
+		Flags: []cli.Flag{
+			internal.DebugFlag,
+		},
 		Commands: []*cli.Command{
 			&app.AppCommand,
 			&server.ServerCommand,

cli/internal/cli.go

@@ -106,6 +106,7 @@ var DebugFlag = &cli.BoolFlag{
 	Name:        "debug",
 	Aliases:     []string{"d"},
 	Destination: &Debug,
+	Persistent:  true,
 	Usage:       "Show DEBUG messages",
 }
 

cli/recipe/diff.go

@@ -17,7 +17,6 @@ var recipeDiffCommand = cli.Command{
 	Aliases:     []string{"d"},
 	ArgsUsage:   "<recipe>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 	},
 	Before:                internal.SubCommandBefore,

cli/recipe/fetch.go

@@ -18,7 +18,6 @@ var recipeFetchCommand = cli.Command{
 	ArgsUsage:   "[<recipe>]",
 	Description: "Retrieves all recipes if no <recipe> argument is passed",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.OfflineFlag,
 	},

cli/recipe/lint.go

@@ -18,7 +18,6 @@ var recipeLintCommand = cli.Command{
 	Aliases:   []string{"l"},
 	ArgsUsage: "<recipe>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OnlyErrorFlag,
 		internal.OfflineFlag,
 		internal.NoInputFlag,

cli/recipe/list.go

@@ -28,7 +28,6 @@ var recipeListCommand = cli.Command{
 	Usage:   "List available recipes",
 	Aliases: []string{"ls"},
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.MachineReadableFlag,
 		patternFlag,
 		internal.OfflineFlag,

cli/recipe/new.go

@@ -35,7 +35,6 @@ var recipeNewCommand = cli.Command{
 	Name:    "new",
 	Aliases: []string{"n"},
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.OfflineFlag,
 		internal.GitNameFlag,

cli/recipe/release.go

@@ -47,7 +47,6 @@ Publish your new release to git.coopcloud.tech with "-p/--publish". This
 requires that you have permission to git push to these repositories and have
 your SSH keys configured on your account.`,
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.DryFlag,
 		internal.MajorFlag,

cli/recipe/reset.go

@@ -18,7 +18,6 @@ var recipeResetCommand = cli.Command{
 	Aliases:     []string{"rs"},
 	ArgsUsage:   "<recipe>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 	},
 	Before:                internal.SubCommandBefore,

cli/recipe/sync.go

@@ -22,7 +22,6 @@ var recipeSyncCommand = cli.Command{
 	Usage:     "Sync recipe version label",
 	ArgsUsage: "<recipe> [<version>]",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.DryFlag,
 		internal.MajorFlag,

cli/recipe/upgrade.go

@@ -61,7 +61,6 @@ EXAMPLE:
     abra recipe upgrade`,
 	ArgsUsage: "<recipe>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.PatchFlag,
 		internal.MinorFlag,

cli/recipe/version.go

@@ -30,7 +30,6 @@ var recipeVersionCommand = cli.Command{
 	Usage:     "List recipe versions",
 	ArgsUsage: "<recipe>",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		internal.NoInputFlag,
 		internal.MachineReadableFlag,

cli/server/add.go

@@ -125,7 +125,6 @@ of your ~/.ssh/config. Checks for a valid online domain will be skipped:
 
   abra server add -D example`,
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.NoDomainChecksFlag,
 		localFlag,

cli/server/prune.go

@@ -43,7 +43,6 @@ app. This can result in unwanted data loss if not used carefully.`,
 	Flags: []cli.Flag{
 		allFilterFlag,
 		volumesFilterFlag,
-		internal.DebugFlag,
 		internal.OfflineFlag,
 		internal.NoInputFlag,
 	},

cli/server/remove.go

@@ -25,7 +25,6 @@ Abra will remove the internal bookkeeping (~/.abra/servers/...) and underlying
 client connection context. This server will then be lost in time, like tears in
 rain.`,
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		internal.NoInputFlag,
 		internal.OfflineFlag,
 	},

cli/updater/updater.go

@@ -50,7 +50,6 @@ var Notify = cli.Command{
 	Aliases: []string{"n"},
 	Usage:   "Check for available upgrades",
 	Flags: []cli.Flag{
-		internal.DebugFlag,
 		majorFlag,
 		internal.OfflineFlag,
 	},