refactor!: cobra migrate

cli/app/deploy.go

@@ -18,41 +18,60 @@ import (
 	"coopcloud.tech/abra/pkg/lint"
 	"coopcloud.tech/abra/pkg/log"
 	"coopcloud.tech/abra/pkg/upstream/stack"
-	"github.com/urfave/cli/v3"
+	"github.com/spf13/cobra"
 )
 
-var appDeployCommand = cli.Command{
-	Name:      "deploy",
-	Aliases:   []string{"d"},
-	Usage:     "Deploy an app",
-	UsageText: "abra app deploy <domain> [<version>] [options]",
-	Flags: []cli.Flag{
-		internal.ForceFlag,
-		internal.ChaosFlag,
-		internal.NoDomainChecksFlag,
-		internal.DontWaitConvergeFlag,
-	},
-	Before: internal.SubCommandBefore,
-	Description: `Deploy an app.
+var AppDeployCommand = &cobra.Command{
+	Use:     "deploy <app> [version] [flags]",
+	Aliases: []string{"d"},
+	Short:   "Deploy an app",
+	Long: `Deploy an app.
 
-This command supports chaos operations. Use "--chaos" to deploy your recipe
-checkout as-is. Recipe commit hashes are also supported values for
-"[<version>]". Please note, "upgrade"/"rollback" do not support chaos
-operations.`,
-	ShellComplete: autocomplete.AppNameComplete,
-	HideHelp:      true,
-	Action: func(ctx context.Context, cmd *cli.Command) error {
+This command supports chaos operations. Use "--chaos/-c" to deploy your recipe
+checkout as-is. Recipe commit hashes are also supported values for "[version]".
+Please note, "upgrade"/"rollback" do not support chaos operations.`,
+	Example: `  # standard deployment
+  abra app deploy 1312.net
+
+  # chaos deployment
+  abra app deploy 1312.net --chaos
+  
+  # deploy specific version
+  abra app deploy 1312.net 2.0.0+1.2.3
+
+  # deploy a specific git hash
+  abra app deploy 1312.net 886db76d`,
+	Args: cobra.RangeArgs(1, 2),
+	ValidArgsFunction: func(
+		cmd *cobra.Command,
+		args []string,
+		toComplete string) ([]string, cobra.ShellCompDirective) {
+		switch l := len(args); l {
+		case 0:
+			return autocomplete.AppNameComplete()
+		case 1:
+			app, err := appPkg.Get(args[0])
+			if err != nil {
+				log.Debugf("autocomplete failed: %s", err)
+				return nil, cobra.ShellCompDirectiveDefault
+			}
+			return autocomplete.RecipeVersionComplete(app.Recipe.Name)
+		default:
+			return nil, cobra.ShellCompDirectiveDefault
+		}
+	},
+	Run: func(cmd *cobra.Command, args []string) {
 		var warnMessages []string
 
-		app := internal.ValidateApp(cmd)
+		app := internal.ValidateApp(args)
 		stackName := app.StackName()
 
-		ok, err := validateChaosXORVersion(cmd.Args())
+		ok, err := validateChaosXORVersion(args)
 		if !ok {
 			log.Fatalf(err.Error())
 		}
 
-		specificVersion := getSpecifiedVersion(cmd.Args())
+		specificVersion := getSpecifiedVersion(args)
 
 		if specificVersion != "" {
 			log.Debugf("overriding env file version (%s) with %s", app.Recipe.Version, specificVersion)
@@ -256,21 +275,54 @@ operations.`,
 		if err := app.WriteRecipeVersion(app.Recipe.Version, false); err != nil {
 			log.Fatalf("writing new recipe version in env file: %s", err)
 		}
-
-		return nil
 	},
 }
 
-// This is not really xor since both can be absent
-//
-//	but, I say we let it slide this time!
-func validateChaosXORVersion(args cli.Args) (bool, error) {
+// validateChaosXORVersion xor checks version/chaos mode
+func validateChaosXORVersion(args []string) (bool, error) {
 	if getSpecifiedVersion(args) != "" && internal.Chaos {
 		return false, errors.New("cannot use <version> and --chaos together")
 	}
 	return true, nil
 }
 
-func getSpecifiedVersion(args cli.Args) string {
-	return args.Get(1)
+// getSpecifiedVersion retrieves the specific version if available
+func getSpecifiedVersion(args []string) string {
+	if len(args) >= 2 {
+		return args[1]
+	}
+	return ""
+}
+
+func init() {
+	AppDeployCommand.Flags().BoolVarP(
+		&internal.Chaos,
+		"chaos",
+		"C",
+		false,
+		"ignore uncommitted recipes changes",
+	)
+
+	AppDeployCommand.Flags().BoolVarP(
+		&internal.Force,
+		"force",
+		"f",
+		false,
+		"perform action without further prompt",
+	)
+
+	AppDeployCommand.Flags().BoolVarP(
+		&internal.NoDomainChecks,
+		"no-domain-checks",
+		"D",
+		false,
+		"disable public DNS checks",
+	)
+
+	AppDeployCommand.Flags().BoolVarP(
+		&internal.DontWaitConverge, "no-converge-checks",
+		"c",
+		false,
+		"do not wait for converge logic checks",
+	)
 }