From 7b6ea764377e8fefc56a0b4361d6d68608150474 Mon Sep 17 00:00:00 2001 From: p4u1 Date: Mon, 10 Feb 2025 15:32:57 +0100 Subject: [PATCH] fix(secret): Checks for enough arguments --- cli/app/secret.go | 4 ++-- tests/integration/app_secret.bats | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/cli/app/secret.go b/cli/app/secret.go index faf8d320..6bda8876 100644 --- a/cli/app/secret.go +++ b/cli/app/secret.go @@ -49,11 +49,11 @@ var AppSecretGenerateCommand = &cobra.Command{ log.Fatal(err) } - if len(args) == 1 && !generateAllSecrets { + if len(args) <= 2 && !generateAllSecrets { log.Fatal("missing arguments [secret]/[version] or '--all'") } - if len(args) > 1 && generateAllSecrets { + if len(args) > 2 && generateAllSecrets { log.Fatal("cannot use '[secret] [version]' and '--all' together") } diff --git a/tests/integration/app_secret.bats b/tests/integration/app_secret.bats index e1f087c0..892cce22 100644 --- a/tests/integration/app_secret.bats +++ b/tests/integration/app_secret.bats @@ -41,6 +41,11 @@ teardown(){ run $ABRA app secret generate "$TEST_APP_DOMAIN" assert_failure + assert_output --partial 'missing arguments' + + run $ABRA app secret generate "$TEST_APP_DOMAIN" test_pass_one + assert_failure + assert_output --partial 'missing arguments' run $ABRA app secret generate "$TEST_APP_DOMAIN" testSecret testVersion --all assert_failure