fix: sort versions upgrade/rollback/list

See toolshed/organising#649

cli/app/list.go

@@ -173,7 +173,7 @@ Use "--status/-S" flag to query all servers for the live deployment status.`,
 							stats.LatestCount++
 						}
 					} else {
-						newUpdates = internal.ReverseStringList(newUpdates)
+						newUpdates = internal.SortVersionsDesc(newUpdates)
 						appStats.Upgrade = strings.Join(newUpdates, "\n")
 						stats.UpgradeCount++
 					}

cli/app/rollback.go

@@ -167,7 +167,7 @@ beforehand.`,
 
 				prompt := &survey.Select{
 					Message: msg,
-					Options: internal.ReverseStringList(availableDowngrades),
+					Options: internal.SortVersionsDesc(availableDowngrades),
 				}
 
 				if err := survey.AskOne(prompt, &chosenDowngrade); err != nil {

cli/app/upgrade.go

@@ -159,7 +159,7 @@ beforehand.`,
 
 				prompt := &survey.Select{
 					Message: msg,
-					Options: internal.ReverseStringList(availableUpgrades),
+					Options: internal.SortVersionsDesc(availableUpgrades),
 				}
 
 				if err := survey.AskOne(prompt, &chosenUpgrade); err != nil {

cli/internal/deploy.go

@@ -3,12 +3,14 @@ package internal
 import (
 	"fmt"
 	"os"
+	"sort"
 	"strings"
 
 	appPkg "coopcloud.tech/abra/pkg/app"
 	"coopcloud.tech/abra/pkg/config"
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/log"
+	"coopcloud.tech/tagcmp"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/charmbracelet/lipgloss"
 	dockerClient "github.com/docker/docker/client"
@@ -274,3 +276,22 @@ func PostCmds(cl *dockerClient.Client, app appPkg.App, commands string) error {
 	}
 	return nil
 }
+
+// SortVersionsDesc sorts versions in descending order.
+func SortVersionsDesc(versions []string) []string {
+	var tags []tagcmp.Tag
+
+	for _, v := range versions {
+		parsed, _ := tagcmp.Parse(v) // skips unsupported tags
+		tags = append(tags, parsed)
+	}
+
+	sort.Sort(tagcmp.ByTagDesc(tags))
+
+	var desc []string
+	for _, t := range tags {
+		desc = append(desc, t.String())
+	}
+
+	return desc
+}

cli/internal/list.go

@@ -1,10 +0,0 @@
-package internal
-
-// ReverseStringList reverses a list of a strings. Roll on Go generics.
-func ReverseStringList(strings []string) []string {
-	for i, j := 0, len(strings)-1; i < j; i, j = i+1, j-1 {
-		strings[i], strings[j] = strings[j], strings[i]
-	}
-
-	return strings
-}