refactor: app new cmd to be easier to read

cli/app/new.go

@@ -16,10 +16,9 @@ import (
 	"github.com/urfave/cli/v2"
 )
 
-var appNewCommand = &cli.Command{
+type Secrets map[string]string
-	Name:  "new",
+
-	Usage: "Create a new app",
+var appNewDescription = `
-	Description: `
 This command takes an app recipe and uses it to create a new app. This new app
 configuration is stored in your ~/.abra directory under the appropriate server.
 
@@ -37,7 +36,12 @@ store them somewhere safe.
 You can use the "--pass/-P" to store these generated passwords locally in a
 pass store (see passwordstore.org for more). The pass command must be available
 on your $PATH.
-`,
+`
+
+var appNewCommand = &cli.Command{
+	Name:        "new",
+	Usage:       "Create a new app",
+	Description: appNewDescription,
 	Flags: []cli.Flag{
 		internal.ServerFlag,
 		internal.DomainFlag,
@@ -46,108 +50,161 @@ on your $PATH.
 		internal.SecretsFlag,
 	},
 	ArgsUsage: "<type>",
-	Action: func(c *cli.Context) error {
+	Action:    action,
-		appType := c.Args().First()
+}
-		if appType == "" {
+
-			internal.ShowSubcommandHelpAndError(c, errors.New("no app type provided"))
+func sanitiseAppName(name string) string {
-			return nil
+	return strings.ReplaceAll(name, ".", "_")
-		}
+}
-
+
-		config.EnsureAbraDirExists()
+func appLookup(appType string) (catalogue.App, error) {
-
+	catl, err := catalogue.ReadAppsCatalogue()
-		appFiles, err := config.LoadAppFiles(internal.Server)
+	if err != nil {
-		if err != nil {
+		return catalogue.App{}, err
-			logrus.Fatal(err)
+	}
-		}
+
-
+	app, ok := catl[appType]
-		catl, err := catalogue.ReadAppsCatalogue()
+	if !ok {
-		if err != nil {
+		return catalogue.App{}, fmt.Errorf("app type does not exist: %s", appType)
-			logrus.Fatal(err)
+	}
-		}
+	if err := app.EnsureExists(); err != nil {
-
+		return catalogue.App{}, err
-		app := catl[appType]
+	}
-		app.EnsureExists()
+	return app, nil
-
+}
-		latestVersion := app.LatestVersion()
+
-		if err := app.EnsureVersion(latestVersion); err != nil {
+// ensureDomainFlag checks if the domain flag was used. if not, asks the user for it
-			logrus.Fatal(err)
+func ensureDomainFlag() error {
-		}
+	if internal.Domain == "" {
-
+		prompt := &survey.Input{
-		servers := appFiles.GetServers()
+			Message: "Specify app domain",
-		if internal.Server == "" {
+		}
-			prompt := &survey.Select{
+		if err := survey.AskOne(prompt, &internal.Domain); err != nil {
-				Message: "Select app server:",
+			return err
-				Options: servers,
+		}
-			}
+	}
-			if err := survey.AskOne(prompt, &internal.Server); err != nil {
+	return nil
-				logrus.Fatal(err)
+}
-			}
+
-		}
+// ensureServerFlag checks if the server flag was used. if not, asks the user for it
-
+func ensureServerFlag() error {
-		if internal.Domain == "" {
+	appFiles, err := config.LoadAppFiles(internal.Server)
-			prompt := &survey.Input{
+	if err != nil {
-				Message: "Specify app domain",
+		return err
-			}
+	}
-			if err := survey.AskOne(prompt, &internal.Domain); err != nil {
+	servers := appFiles.GetServers()
-				logrus.Fatal(err)
+	if internal.Server == "" {
-			}
+		prompt := &survey.Select{
-		}
+			Message: "Select app server:",
-
+			Options: servers,
-		if internal.AppName == "" {
+		}
-			prompt := &survey.Input{
+		if err := survey.AskOne(prompt, &internal.Server); err != nil {
-				Message: "Specify app name:",
+			return err
-				Default: strings.ReplaceAll(internal.Domain, ".", "_"),
+		}
-			}
+	}
-			if err := survey.AskOne(prompt, &internal.AppName); err != nil {
+	return nil
-				logrus.Fatal(err)
+}
-			}
+
-		}
+// ensureServerFlag checks if the AppName flag was used. if not, asks the user for it
-
+func ensureAppNameFlag() error {
-		sanitisedAppName := strings.ReplaceAll(internal.AppName, ".", "_")
+	if internal.AppName == "" {
-		if len(sanitisedAppName) > 45 {
+		prompt := &survey.Input{
-			logrus.Fatal(fmt.Errorf("'%s' cannot be longer than 45 characters", sanitisedAppName))
+			Message: "Specify app name:",
-		}
+			Default: sanitiseAppName(internal.Domain),
-
+		}
-		if err := config.CopyAppEnvSample(appType, internal.AppName, internal.Server); err != nil {
+		if err := survey.AskOne(prompt, &internal.AppName); err != nil {
-			logrus.Fatal(err)
+			return err
-		}
+		}
-
+	}
-		secrets := make(map[string]string)
+	return nil
-		if internal.Secrets {
+}
-			appEnvPath := path.Join(config.ABRA_DIR, "servers", internal.Server, fmt.Sprintf("%s.env", sanitisedAppName))
+
-			appEnv, err := config.ReadEnv(appEnvPath)
+func createSecrets(sanitisedAppName string) (Secrets, error) {
-			if err != nil {
+	appEnvPath := path.Join(config.ABRA_DIR, "servers", internal.Server, fmt.Sprintf("%s.env", sanitisedAppName))
-				logrus.Fatal(err)
+	appEnv, err := config.ReadEnv(appEnvPath)
-			}
+	if err != nil {
-			secretEnvVars := secret.ReadSecretEnvVars(appEnv)
+		return nil, err
-			secrets, err = secret.GenerateSecrets(secretEnvVars, sanitisedAppName, internal.Server)
+	}
-			if err != nil {
+
-				logrus.Fatal(err)
+	secretEnvVars := secret.ReadSecretEnvVars(appEnv)
-			}
+	secrets, err := secret.GenerateSecrets(secretEnvVars, sanitisedAppName, internal.Server)
-			if internal.Pass {
+	if err != nil {
-				for secretName := range secrets {
+		return nil, err
-					secretValue := secrets[secretName]
+	}
-					if err := secret.PassInsertSecret(secretValue, secretName, sanitisedAppName, internal.Server); err != nil {
+
-						logrus.Fatal(err)
+	if internal.Pass {
-					}
+		for secretName := range secrets {
-				}
+			secretValue := secrets[secretName]
-			}
+			if err := secret.PassInsertSecret(secretValue, secretName, sanitisedAppName, internal.Server); err != nil {
-		}
+				return nil, err
-
+			}
-		tableCol := []string{"Name", "Domain", "Type", "Server"}
+		}
-		table := abraFormatter.CreateTable(tableCol)
+	}
-		table.Append([]string{sanitisedAppName, internal.Domain, appType, internal.Server})
+	return secrets, nil
-		table.Render()
+}
-
+
-		if internal.Secrets {
+func action(c *cli.Context) error {
-			secretCols := []string{"Name", "Value"}
+	appType := c.Args().First()
-			secretTable := abraFormatter.CreateTable(secretCols)
+	if appType == "" {
-			for secret := range secrets {
+		internal.ShowSubcommandHelpAndError(c, errors.New("no app type provided"))
-				secretTable.Append([]string{secret, secrets[secret]})
+	}
-			}
+
-			secretTable.Render()
+	if err := config.EnsureAbraDirExists(); err != nil {
-		}
+		logrus.Fatal(err)
-
+	}
-		return nil
+
-	},
+	app, err := appLookup(appType)
+	if err != nil {
+		logrus.Fatal(err)
+	}
+
+	latestVersion := app.LatestVersion()
+	if err := app.EnsureVersion(latestVersion); err != nil {
+		logrus.Fatal(err)
+	}
+
+	// These use the flag from internal.x to check and edit so no need to return anything
+	if err := ensureServerFlag(); err != nil {
+		logrus.Fatal(err)
+	}
+
+	if err := ensureDomainFlag(); err != nil {
+		logrus.Fatal(err)
+	}
+
+	if err := ensureAppNameFlag(); err != nil {
+		logrus.Fatal(err)
+	}
+
+	sanitisedAppName := sanitiseAppName(internal.AppName)
+	if len(sanitisedAppName) > 45 {
+		logrus.Fatalf("'%s' cannot be longer than 45 characters", sanitisedAppName)
+	}
+
+	if err := config.CopyAppEnvSample(appType, internal.AppName, internal.Server); err != nil {
+		logrus.Fatal(err)
+	}
+
+	if internal.Secrets {
+		secrets, err := createSecrets(sanitisedAppName)
+		if err != nil {
+			logrus.Fatal(err)
+		}
+
+		secretCols := []string{"Name", "Value"}
+		secretTable := abraFormatter.CreateTable(secretCols)
+		for secret := range secrets {
+			secretTable.Append([]string{secret, secrets[secret]})
+		}
+		// Defer secret table first so it is last no matter what
+		defer secretTable.Render()
+	}
+
+	tableCol := []string{"Name", "Domain", "Type", "Server"}
+	table := abraFormatter.CreateTable(tableCol)
+	table.Append([]string{sanitisedAppName, internal.Domain, appType, internal.Server})
+	defer table.Render()
+
+	return nil
+
 }