feat: show proposed secret version changes during deploy

pkg/client/configs.go

@@ -3,7 +3,6 @@ package client
 import (
 	"context"
 	"errors"
-	"strings"
 
 	"coopcloud.tech/abra/pkg/i18n"
 	"github.com/docker/docker/api/types/filters"
@@ -38,12 +37,3 @@ func RemoveConfigs(cl *client.Client, ctx context.Context, configNames []string,
 	}
 	return nil
 }
-
-// GetConfigNameAndVersion parses a full config name like `app_example_com_someconf_v1` to extract name and version, ("someconf", "v1")
-func GetConfigNameAndVersion(fullName string, stackName string) (string, string, error) {
-	name := strings.TrimPrefix(fullName, stackName+"_")
-	if lastUnderscore := strings.LastIndex(name, "_"); lastUnderscore != -1 {
-		return name[0:lastUnderscore], name[lastUnderscore+1:], nil
-	}
-	return "", "", errors.New(i18n.G("can't parse version from config '%s'", fullName))
-}

pkg/client/configs_test.go

@@ -1,89 +0,0 @@
-package client
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/assert"
-)
-
-func TestGetConfigNameAndVersion(t *testing.T) {
-	tests := []struct {
-		name        string
-		fullName    string
-		stackName   string
-		expected    string
-		expectedVer string
-		expectError bool
-	}{
-		{
-			name:        "valid config with version",
-			fullName:    "myapp_database_v2",
-			stackName:   "myapp",
-			expected:    "database",
-			expectedVer: "v2",
-			expectError: false,
-		},
-		{
-			name:        "valid config with numeric version",
-			fullName:    "myapp_redis_1",
-			stackName:   "myapp",
-			expected:    "redis",
-			expectedVer: "1",
-			expectError: false,
-		},
-		{
-			name:        "config without underscore in name",
-			fullName:    "myapp_db_v1",
-			stackName:   "myapp",
-			expected:    "db",
-			expectedVer: "v1",
-			expectError: false,
-		},
-		{
-			name:        "config with multiple underscores",
-			fullName:    "myapp_my_database_v3",
-			stackName:   "myapp",
-			expected:    "my_database",
-			expectedVer: "v3",
-			expectError: false,
-		},
-		{
-			name:        "invalid config - no version",
-			fullName:    "myapp_database",
-			stackName:   "myapp",
-			expectError: true,
-		},
-		{
-			name:        "empty config name",
-			fullName:    "myapp__v1",
-			stackName:   "myapp",
-			expected:    "",
-			expectedVer: "v1",
-			expectError: false,
-		},
-		{
-			name:        "wrong stack prefix",
-			fullName:    "otherapp_database_v1",
-			stackName:   "myapp",
-			expected:    "otherapp_database",
-			expectedVer: "v1",
-			expectError: false,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			name, version, err := GetConfigNameAndVersion(tt.fullName, tt.stackName)
-
-			if tt.expectError {
-				assert.Error(t, err)
-				assert.Empty(t, name)
-				assert.Empty(t, version)
-			} else {
-				assert.NoError(t, err)
-				assert.Equal(t, tt.expected, name)
-				assert.Equal(t, tt.expectedVer, version)
-			}
-		})
-	}
-}