From e6b35e85244b5e12c59ba4dd50eec2719ecdceb4 Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Wed, 22 May 2024 10:21:31 +0200
Subject: [PATCH] fix(upgrade): make upgrade --chaos working again

---
 cli/app/upgrade.go | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/cli/app/upgrade.go b/cli/app/upgrade.go
index 736aede7..366a5932 100644
--- a/cli/app/upgrade.go
+++ b/cli/app/upgrade.go
@@ -194,23 +194,24 @@ recipes.
 		// check out the tag and then they'll appear to be missing. this covers
 		// when we obviously will forget to write release notes before publishing
 		var releaseNotes string
-		for _, version := range versions {
-			parsedVersion, err := tagcmp.Parse(version)
-			if err != nil {
-				logrus.Fatal(err)
-			}
+		if chosenUpgrade != "" {
 			parsedChosenUpgrade, err := tagcmp.Parse(chosenUpgrade)
 			if err != nil {
 				logrus.Fatal(err)
 			}
-
-			if parsedVersion.IsGreaterThan(parsedDeployedVersion) && parsedVersion.IsLessThan(parsedChosenUpgrade) {
-				note, err := internal.GetReleaseNotes(app.Recipe, version)
+			for _, version := range versions {
+				parsedVersion, err := tagcmp.Parse(version)
 				if err != nil {
-					return err
+					logrus.Fatal(err)
 				}
-				if note != "" {
-					releaseNotes += fmt.Sprintf("%s\n", note)
+				if parsedVersion.IsGreaterThan(parsedDeployedVersion) && parsedVersion.IsLessThan(parsedChosenUpgrade) {
+					note, err := internal.GetReleaseNotes(app.Recipe, version)
+					if err != nil {
+						return err
+					}
+					if note != "" {
+						releaseNotes += fmt.Sprintf("%s\n", note)
+					}
 				}
 			}
 		}