toolshed/abra
4
4
Fork 23
Code Issues 82 Pull Requests 13 Packages Releases 45 Activity

Support local apps.json loading #10

Merged
decentral1se merged 1 commits from apps-json-handling into main 2021-07-21 20:44:50 +00:00
Conversation 1 Commits 1 Files Changed 2
+105 -32
decentral1se commented 2021-07-21 16:29:31 +00:00
Owner
Copy Link
Copy Source

This logic supports the following cases:

  • Download a fresh apps.json and load it if missing
  • Check if a local apps.json is old and get a fresh one if so
  • Always save a local copy after downloading a fresh apps.json

The http.Head() call is faster than a http.Get() call (only carries back respones headers) and aims to make the more general case more performant - you have the latest copy of the apps.json and don't need to download another one. This a direct port of our Bash implementation logic.

Closes https://git.autonomic.zone/coop-cloud/go-abra/issues/9.

This logic supports the following cases: - Download a fresh apps.json and load it if missing - Check if a local apps.json is old and get a fresh one if so - Always save a local copy after downloading a fresh apps.json The http.Head() call is faster than a http.Get() call (only carries back respones headers) and aims to make the more general case more performant - you have the latest copy of the apps.json and don't need to download another one. This a direct port of our Bash implementation logic. Closes https://git.autonomic.zone/coop-cloud/go-abra/issues/9.
decentral1se requested review from roxxers 2021-07-21 16:30:10 +00:00
decentral1se force-pushed apps-json-handling from 9c84438f0a to 1f6c0e8c4b 2021-07-21 20:43:07 +00:00 Compare
decentral1se changed title from WIP: support local apps.json loading to Support local apps.json loading 2021-07-21 20:43:15 +00:00
decentral1se removed review request for roxxers 2021-07-21 20:43:17 +00:00
decentral1se merged commit a4a8997f57 into main 2021-07-21 20:44:50 +00:00
decentral1se deleted branch apps-json-handling 2021-07-21 20:44:55 +00:00
decentral1se commented 2021-07-21 20:44:58 +00:00
Author
Owner
Copy Link
Copy Source

Took another run at this, gonna keep moving 🏃‍♀️

Took another run at this, gonna keep moving 🏃‍♀️
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 build
go build related issues
 ci/cd
Building things with CI/CD
 critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
 design
UI/UX
 documentation
Documenting all the things
 duplicate
This issue or pull request already exists
 easy-first-issue
Something for new people to get stuck into. We hope it's easy!
 enhancement
New feature
 help wanted
Need some help
 i10n
Everything to do with localisation
 i18n
Everything to do with internationalisation
 installer
Everything to do with the install script.
 invalid
Something is wrong
 question
More information is needed
 release
Release management
 release-candidate
Related to the new release candidate
 security
Security related
 tech-debt
test
Unit/integration testing
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm BornDeleuze Brooke carla cas (Cassowary) coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) iexos jade (Jade Ambrose) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) moosemower moritz notplants oxaliq (sorrel) p4u1 pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) renovate-bot (Comrade Renovate Bot) ripclap simon sixsmith (Sixsmith) stevensting trav (Trav Fryer) val (val (he/him)) yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#10