toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

createTable customisation don't align output #16

New Issue
Closed
opened 2021-07-27 19:35:17 +00:00 by decentral1se · 6 comments
decentral1se commented 2021-07-27 19:35:17 +00:00
Owner
Copy Link
➜  go-abra (main) ✔ ./abra app ls -s utaw.autonomic.zone -S
SERVER             	TYPE     	DOMAIN                     	STATUS   
  utaw.autonomic.zone  keycloak   login.utaw.autonomic.zone    deployed  
                       nextcloud  cloud.utaw.autonomic.zone    deployed  
                       traefik    traefik.utaw.autonomic.zone  deployed

The default layout does align:

➜  go-abra (main) ✗ ./abra app ls -s utaw.autonomic.zone -S
+---------------------+-----------+-----------------------------+----------+
| SERVER              | TYPE      | DOMAIN                      | STATUS   |
+---------------------+-----------+-----------------------------+----------+
| utaw.autonomic.zone | keycloak  | login.utaw.autonomic.zone   | deployed |
|                     | nextcloud | cloud.utaw.autonomic.zone   | deployed |
|                     | traefik   | traefik.utaw.autonomic.zone | deployed |
+---------------------+-----------+-----------------------------+----------+

Not sure what needs to be tweaked in 0e75350985/cli/formatter.go (L34-L52)?

``` ➜ go-abra (main) ✔ ./abra app ls -s utaw.autonomic.zone -S SERVER TYPE DOMAIN STATUS utaw.autonomic.zone keycloak login.utaw.autonomic.zone deployed nextcloud cloud.utaw.autonomic.zone deployed traefik traefik.utaw.autonomic.zone deployed ``` The default layout does align: ``` ➜ go-abra (main) ✗ ./abra app ls -s utaw.autonomic.zone -S +---------------------+-----------+-----------------------------+----------+ | SERVER | TYPE | DOMAIN | STATUS | +---------------------+-----------+-----------------------------+----------+ | utaw.autonomic.zone | keycloak | login.utaw.autonomic.zone | deployed | | | nextcloud | cloud.utaw.autonomic.zone | deployed | | | traefik | traefik.utaw.autonomic.zone | deployed | +---------------------+-----------+-----------------------------+----------+ ``` Not sure what needs to be tweaked in https://git.coopcloud.tech/coop-cloud/go-abra/src/commit/0e75350985522ae68bc322bb6426e7da7a6952dc/cli/formatter.go#L34-L52?
decentral1se added the
bug
 label 2021-07-27 19:35:17 +00:00
roxxers commented 2021-07-31 20:10:18 +00:00
Copy Link

Ill be moving to tabby on this so this is due to change. Or at least another formatter.

Ill be moving to tabby on this so this is due to change. Or at least another formatter.
decentral1se commented 2021-08-01 07:28:18 +00:00
Author
Owner
Copy Link

Why? Seems fine to me, we can just use the default again? I'd like to keep the cell merging in whatever library we use, that really helps the layout for large lists like in 805defec09/cli/app.go (L216).

Why? Seems fine to me, we can just use the default again? I'd like to keep the cell merging in whatever library we use, that really helps the layout for large lists like in https://git.coopcloud.tech/coop-cloud/go-abra/src/commit/805defec094078aeb3ce7edc5c0cfdc6636e3c79/cli/app.go#L216.
roxxers commented 2021-08-02 00:15:13 +00:00
Copy Link

never used the default as I thought it was a bit too busy. I'd rather something more sinple. Plus there is other libraries to look at. I am not a fan of the way the table needs to be created. This was always just a patch work to fix down the line.

never used the default as I thought it was a bit too busy. I'd rather something more sinple. Plus there is other libraries to look at. I am not a fan of the way the table needs to be created. This was always just a patch work to fix down the line.
roxxers commented 2021-08-02 04:25:38 +00:00
Copy Link

ok so I think we either go with the default table if that works nad we can mess with it so it is something we like or move to something like https://github.com/jedib0t/go-pretty.

ok so I think we either go with the default table if that works nad we can mess with it so it is something we like or move to something like https://github.com/jedib0t/go-pretty.
decentral1se commented 2021-08-02 08:15:57 +00:00
Author
Owner
Copy Link

Dayum go-pretty has another thing I really needed, this kind of goroutine suporting progress bar loading stuff. That would be amazing to have for usability purposes when we're querying multiple remote contexts. I'd be down for switching for that. It also has merging I see. Nice!

Dayum `go-pretty` has another thing I really needed, this kind of goroutine suporting progress bar loading stuff. That would be amazing to have for usability purposes when we're querying multiple remote contexts. I'd be down for switching for that. It also has merging I see. Nice!
decentral1se added this to the (deleted) milestone 2021-09-04 21:06:25 +00:00
decentral1se self-assigned this 2021-09-06 15:36:24 +00:00
decentral1se commented 2021-09-07 06:46:09 +00:00
Author
Owner
Copy Link

Lazily just re-enabled the default as I couldn't figure out how to keep the more minimal styles and have alignment (which I think is important for understanding the often complex output listing). go-pretty migration coming one day ™️

Lazily just re-enabled the default as I couldn't figure out how to keep the more minimal styles and have alignment (which I think is important for understanding the often complex output listing). `go-pretty` migration coming one day :tm:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees decentral1se
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#16
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?