toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

bug: breaking test "TestReadEnv" via refactoring #18

New Issue
Closed
opened 2021-07-31 20:07:50 +00:00 by roxxers · 3 comments
roxxers commented 2021-07-31 20:07:50 +00:00
Copy Link

5771f6c158/config/env.go (L217)

@decentral1se Broke the tests in this commit by not using a refactoring tool. Found it amusing because we talked about not breaking tests and code on main lol. Will fix but there is like no way to just code review a commit?

https://git.coopcloud.tech/coop-cloud/go-abra/src/commit/5771f6c158ece015ace12569c640cd9a6c263b10/config/env.go#L217 @decentral1se Broke the tests in this commit by not using a refactoring tool. Found it amusing because we talked about not breaking tests and code on main lol. Will fix but there is like no way to just code review a commit?
roxxers commented 2021-07-31 20:08:31 +00:00
Author
Copy Link

To be clear, exporting this function breaks the test since it was calling it before as an unexported function

To be clear, exporting this function breaks the test since it was calling it before as an unexported function
roxxers commented 2021-07-31 20:09:13 +00:00
Author
Copy Link

Fixed in f958b888b6

Fixed in f958b888b60e89bed9e70dc76a6fd4d7c5b6e89c
decentral1se commented 2021-08-02 08:17:15 +00:00
Owner
Copy Link

That's a lot of noise for a single character fix @roxxers. Just message me directly next time instead? I didn't have time to explain fully on that call but what I meant was that we should at the minimum make sure each commit compiles (I wasn't talking about tests).

That's a lot of noise for a single character fix @roxxers. Just message me directly next time instead? I didn't have time to explain fully on that call but what I meant was that we should at the minimum make sure each commit compiles (I wasn't talking about tests).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#18
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?