toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

Change design of commands and lib to use client more effectively #37

New Issue
Closed
opened 2021-08-03 00:33:25 +00:00 by roxxers · 6 comments
roxxers commented 2021-08-03 00:33:25 +00:00
Copy Link

Would be much better to have a client we make in the cli and then pass down to commands to save on memory and to make customising the docker config dir easier

Would be much better to have a client we make in the cli and then pass down to commands to save on memory and to make customising the docker config dir easier
decentral1se commented 2021-08-03 09:22:42 +00:00
Owner
Copy Link

Yes, perfect 💯

Also the context? Idk if that would cause issues tho.

Yes, perfect 💯 Also the context? Idk if that would cause issues tho.
decentral1se commented 2021-09-03 10:26:04 +00:00
Owner
Copy Link

Let us know when you kick this off @roxxers so we don't run into a merge conflict the size of Texas. Lotta churn going on.

Let us know when you kick this off @roxxers so we don't run into a merge conflict the size of Texas. Lotta churn going on.
decentral1se added the
enhancement
 label 2021-09-03 10:26:13 +00:00
roxxers commented 2021-09-03 15:02:47 +00:00
Author
Copy Link

will do

will do
🚀 1
decentral1se added this to the (deleted) milestone 2021-09-04 21:03:19 +00:00
decentral1se commented 2021-09-05 20:12:43 +00:00
Owner
Copy Link

https://github.com/urfave/cli/issues/1009

https://github.com/urfave/cli/issues/1009
👍 1
roxxers was assigned by decentral1se 2021-09-06 15:17:00 +00:00
roxxers commented 2021-09-06 20:13:49 +00:00
Author
Copy Link

https://github.com/urfave/cli/issues/1009

Thanks for pointing it out. I think there might be a use for it. For client stuff tho that will have t obe in the command since it needs to know what context you are using which just means some extra lib code and replacing the line where we get the client

> https://github.com/urfave/cli/issues/1009 Thanks for pointing it out. I think there might be a use for it. For client stuff tho that will have t obe in the command since it needs to know what context you are using which just means some extra lib code and replacing the line where we get the client
roxxers commented 2021-09-06 20:24:49 +00:00
Author
Copy Link

Turns out the cli context has its own context object so I can also just reuse that anytime we need that object

Turns out the cli context has its own context object so I can also just reuse that anytime we need that object
decentral1se removed this from the (deleted) milestone 2021-09-07 09:01:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#37
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?