toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

Release notes not shown when upgrading app #488

New Issue
Closed
opened 2025-01-20 12:33:58 +00:00 by stevensting · 2 comments
stevensting commented 2025-01-20 12:33:58 +00:00
Copy Link

I created a new vaultwarden release: https://git.coopcloud.tech/coop-cloud/vaultwarden/releases/tag/1.0.4+1.32.7

Afterwards abra (version 0.10.0-rc1-beta-8af87aa) shows the following when upgrading vaultwarden:

WARN no release notes available for 1.0.4+1.32.7

I created a new vaultwarden release: https://git.coopcloud.tech/coop-cloud/vaultwarden/releases/tag/1.0.4+1.32.7 Afterwards abra (version 0.10.0-rc1-beta-8af87aa) shows the following when upgrading vaultwarden: `WARN no release notes available for 1.0.4+1.32.7`
👀 1
decentral1se added the
bug
release-candidate
 labels 2025-01-20 20:44:47 +00:00
decentral1se added this to the abra v0.10.0 project 2025-01-20 20:44:57 +00:00
p4u1 commented 2025-02-10 15:14:14 +00:00
Member
Copy Link

The problem is, that the release not was added after the recipe release. Not sure what todo in that case... Should we checkout the lastest commit for retrieving release notes? What do you think @decentral1se

The problem is, that the release not was added after the recipe release. Not sure what todo in that case... Should we checkout the lastest commit for retrieving release notes? What do you think @decentral1se
👍 1
decentral1se commented 2025-02-11 10:18:27 +00:00
Owner
Copy Link

@p4u1 thanks for taking a look.

I think I attempted to do this but reviewing it now, it doesn't look exactly right. Also, I guess there is no test to cover this eventuality, which we should try to do this time around. See what you think?

cli/app/upgrade.go Lines 144 to 150 in d09a19a385
// NOTE(d1): if release notes written after git tag published, read them
// before we check out the tag and then they'll appear to be missing. this
// covers when we obviously will forget to write release notes before
// publishing
if err := getReleaseNotes(app, versions, chosenUpgrade, deployMeta, &upgradeReleaseNotes); err != nil {
log.Fatal(err)
}

@p4u1 thanks for taking a look. I think I attempted to do this but reviewing it now, it doesn't look exactly right. Also, I guess there is no test to cover this eventuality, which we should try to do this time around. See what you think? https://git.coopcloud.tech/toolshed/abra/src/commit/d09a19a385a9719a8ca5c312dfc52d45bde0fe2e/cli/app/upgrade.go#L144-L150
p4u1 self-assigned this 2025-03-13 09:18:38 +00:00
p4u1 closed this issue 2025-03-21 10:25:48 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:00:59 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:01:01 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:08 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:10 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-19 07:28:29 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-21 17:48:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
bug
release-candidate
Milestone
No items
No Milestone
Projects
Clear projects
No project abra v0.10.0
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees p4u1
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#488
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?