toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 27 Pull Requests 3 Packages Releases 40 Activity

fix: app new with chaos should just take the local repo as it is #495

Merged
p4u1 merged 1 commits from p4u1/abra:app-new-chaos into main 2025-02-10 14:00:42 +00:00
Conversation 2 Commits 1 Files Changed 2 +9 -32
p4u1 commented 2025-01-31 12:54:44 +00:00
Member
Copy Link

Fixes #494

Fixes https://git.coopcloud.tech/toolshed/abra/issues/494
p4u1 changed title from app-new-chaos to fix: app new with chaos should just take the local repo as it is 2025-01-31 14:41:26 +00:00
decentral1se added this to the abra v0.10.0 project 2025-02-05 14:01:31 +00:00
decentral1se commented 2025-02-05 15:16:12 +00:00
Owner
Copy Link

@p4u1 hey, this looks good, thanks! However, then I was like, what the hell are these changes doing in this block in the first place 🤔 It was implemented in #476 and I think maybe I mixed up the implementation? Could you check those integration tests pass? In general, i would expect this case to be tested heavily, so I'm surprised to see it fail. Can we add another integration test to ensure this doesn't break again?

@p4u1 hey, this looks good, thanks! However, then I was like, what the hell are these changes doing in this block in the first place 🤔 It was implemented in https://git.coopcloud.tech/toolshed/abra/pulls/476 and I think maybe I mixed up the implementation? Could you check those integration tests pass? In general, i would expect this case to be tested heavily, so I'm surprised to see it fail. Can we add another integration test to ensure this doesn't break again?
p4u1 force-pushed app-new-chaos from 4d280919d0 to cee0fa7c8e 2025-02-10 13:58:20 +00:00 Compare
p4u1 commented 2025-02-10 13:59:14 +00:00
Author
Member
Copy Link

@decentral1se There was an existing integration test, but it tested for the wrong behavior. I adjusted the test

@decentral1se There was an existing integration test, but it tested for the wrong behavior. I adjusted the test
❤️ 1
p4u1 merged commit 15d6b1a2a5 into main 2025-02-10 14:00:42 +00:00
p4u1 deleted branch app-new-chaos 2025-02-10 14:00:43 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:00:59 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:01:01 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:08 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:10 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-19 07:28:29 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-21 17:48:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project abra v0.10.0
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#495
No description provided.
Delete Branch "p4u1/abra:app-new-chaos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?