fix: abra app rm trying to remove secrets twice #50

knoflook · 2021-08-11T10:55:12Z

knoflook commented

2021-08-11 10:55:12 +00:00

No description provided.

knoflook force-pushed main from 9da1108150 to c9d5e8f6cc

2021-08-11 11:16:18 +00:00

Compare

decentral1se approved these changes 2021-08-11 11:16:37 +00:00

decentral1se left a comment

LGTM

(idk if our convention here is var foo []string or foo := []string{}, @roxxers got a nugget of wisdom for us?)

LGTM (idk if our convention here is `var foo []string` or `foo := []string{}`, @roxxers got a nugget of wisdom for us?)

knoflook changed title from ~~Fix trying to remove secrets twice~~ to fix: abra app rm trying to remove secrets twice

2021-08-11 11:18:15 +00:00

knoflook commented

2021-08-11 11:22:17 +00:00

it looks like the convention is var name []string indeed

client/convert/service.go:		var aliases []string
client/convert/service.go:	var output []string
client/convert/service.go:	var o []string
client/stack/loader.go:	var msgs []string
cli/server/list.go:			var row []string
cli/app/ps.go:		var conTable [][]string
cli/app/list.go:			var tableRow []string
cli/recipe/recipe.go:			var compatibleStrings []string
config/env_test.go:var tFolders = []string{"folder1", "folder2"}
config/env_test.go:var tFiles = []string{"bar", "foo"}
config/env_test.go:// var expectedServerNames = []string{"evil.corp"}
config/env_test.go:	var fileNames []string
config/env.go:	var unique []string
config/env.go:	var folders []string

it looks like the convention is `var name []string` indeed ``` client/convert/service.go: var aliases []string client/convert/service.go: var output []string client/convert/service.go: var o []string client/stack/loader.go: var msgs []string cli/server/list.go: var row []string cli/app/ps.go: var conTable [][]string cli/app/list.go: var tableRow []string cli/recipe/recipe.go: var compatibleStrings []string config/env_test.go:var tFolders = []string{"folder1", "folder2"} config/env_test.go:var tFiles = []string{"bar", "foo"} config/env_test.go:// var expectedServerNames = []string{"evil.corp"} config/env_test.go: var fileNames []string config/env.go: var unique []string config/env.go: var folders []string ```

roxxers commented

2021-08-11 11:22:25 +00:00

First-time contributor

(idk if our convention here is var foo []string or foo := []string{}, @roxxers got a nugget of wisdom for us?)

var foo []string is way better initalising an empty version of a type. The latter is like technically fine but I really only like using it when actually defining items in the struct or slice.

Edit: looking into the actual differences between these methods, the former means we don't actually need to initalise the data in the type while the latter forces that. So yeah I'd prefer the former unless we had data already to input.

https://www.geeksforgeeks.org/difference-between-var-keyword-and-short-declaration-operator-in-golang/

> (idk if our convention here is var foo []string or foo := []string{}, @roxxers got a nugget of wisdom for us?) `var foo []string` is way better initalising an empty version of a type. The latter is like technically fine but I really only like using it when actually defining items in the struct or slice. Edit: looking into the actual differences between these methods, the former means we don't actually need to initalise the data in the type while the latter forces that. So yeah I'd prefer the former unless we had data already to input. https://www.geeksforgeeks.org/difference-between-var-keyword-and-short-declaration-operator-in-golang/

knoflook commented

2021-08-12 08:43:44 +00:00

(idk if our convention here is var foo []string or foo := []string{}, @roxxers got a nugget of wisdom for us?)

var foo []string is way better initalising an empty version of a type. The latter is like technically fine but I really only like using it when actually defining items in the struct or slice.

Edit: looking into the actual differences between these methods, the former means we don't actually need to initalise the data in the type while the latter forces that. So yeah I'd prefer the former unless we had data already to input.

https://www.geeksforgeeks.org/difference-between-var-keyword-and-short-declaration-operator-in-golang/

So does that mean it's good for merging?

> > (idk if our convention here is var foo []string or foo := []string{}, @roxxers got a nugget of wisdom for us?) > > `var foo []string` is way better initalising an empty version of a type. The latter is like technically fine but I really only like using it when actually defining items in the struct or slice. > > Edit: looking into the actual differences between these methods, the former means we don't actually need to initalise the data in the type while the latter forces that. So yeah I'd prefer the former unless we had data already to input. > > https://www.geeksforgeeks.org/difference-between-var-keyword-and-short-declaration-operator-in-golang/ So does that mean it's good for merging?

knoflook force-pushed main from c9d5e8f6cc to 4b0168139d

2021-08-12 08:44:58 +00:00

Compare

knoflook force-pushed main from 4b0168139d to 4910914c2d

2021-08-12 08:47:05 +00:00

Compare

knoflook force-pushed main from 4910914c2d to fde9fe1c1f

2021-08-12 08:48:24 +00:00

Compare

knoflook force-pushed main from fde9fe1c1f to cefad74e22

2021-08-12 11:01:46 +00:00

Compare

roxxers merged commit 6f0eff5919 into main

2021-08-12 13:22:05 +00:00

roxxers referenced this issue from a commit

2021-08-12 13:22:05 +00:00

Merge pull request 'fix: abra app rm trying to remove secrets twice' (#50) from knoflook/go-abra:main into main

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#50

Allow edits from maintainers