toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 27 Pull Requests 3 Packages Releases 40 Activity

Warn if env vars from .env are not threaded via environment stanza #530

New Issue
Open
opened 2025-04-14 22:04:17 +00:00 by decentral1se · 1 comment
decentral1se commented 2025-04-14 22:04:17 +00:00
Owner
Copy Link

If FOO=... in the .env is there but

service:
  app:
    environment:
      - FOO

Is not. This means FOO will never make it into the container.

We'd need to take care to only compare what is uncommented in the env var and what is merged together from all the stanzas and $COMPOSE_FILE entries. I believe the docker libs do this for us and we can make a simple comparison.

Again, UI/UX is a question that I don't have a good answer for. Where should this end up being shown?

New people run into this situation often while picking things up.

If `FOO=...` in the `.env` is there but ```yaml service: app: environment: - FOO ``` Is not. This means `FOO` will never make it into the container. We'd need to take care to only compare what is uncommented in the env var and what is merged together from all the stanzas and `$COMPOSE_FILE` entries. I believe the docker libs do this for us and we can make a simple comparison. Again, UI/UX is a question that I don't have a good answer for. Where should this end up being shown? New people run into this situation often while picking things up.
decentral1se added the
enhancement
 label 2025-04-14 22:04:17 +00:00
decentral1se added this to the Abra v0.10.1 project 2025-04-20 05:48:30 +00:00
decentral1se moved this to Backlog in Abra v0.10.1 on 2025-04-20 06:06:40 +00:00
decentral1se moved this to Backlog in Abra v0.10.1 on 2025-04-21 19:08:15 +00:00
decentral1se moved this to Backlog in Abra v0.10.1 on 2025-04-21 19:08:25 +00:00
decentral1se moved this to Backlog in Abra v0.10.1 on 2025-04-24 08:58:35 +00:00
decentral1se moved this to Backlog in Abra v0.10.1 on 2025-04-24 08:58:37 +00:00
decentral1se moved this to Backlog in Abra v0.10.1 on 2025-04-24 08:58:38 +00:00
decentral1se removed this from the Abra v0.10.1 project 2025-04-24 09:01:07 +00:00
3wordchant commented 2025-05-03 21:48:48 +00:00
Owner
Copy Link

Again, UI/UX is a question that I don't have a good answer for. Where should this end up being shown?

I think we already have a warning for variables which aren't defined during abra app deploy, could we show this kind of warning there too?

> Again, UI/UX is a question that I don't have a good answer for. Where should this end up being shown? I think we already have a warning for variables which aren't defined during `abra app deploy`, could we show this kind of warning there too?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#530
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?