abra 0.10 app deploy output is less informative #550
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
previously
abra app deploy
listed the secrets and configs it was creating or reusing, but now it only shows progress of container deployment. i found the previous output useful to quickly check if the correct version of things was being deployed, specially when doing chaotic stuff.unsure now if i should get used to it or claim for it to come back :P
coop-cloud/hedgedoc#17 (comment)
There is some discussion already to add this stuff back. What do you think about only showing this information when it changed? See #537 (comment)
showing it when it changes sounds good!
Yeh apologies, I'm kinda freestyling the deploy output and it's still not great IMHO.
All those messages from before are now moved to
DEBUG
logging messages, so can easily be brought back after "initialising deploy" or whatever it says now. The only issue with "when it changed" is that it only shows when it changes on <v0.10.x
? E.g. create/update. So, do we mean that we ignore an "update" (you already know it was created?).Merging these two in here:
Some stuff is for "before deploy" (overview?) and others for "post deploy" (but we have UI for that yet besides logs).
Related: #556
An attempt at UI design
Original:
Secrets
Secrets
(showing incipient upgrade if possible, otherwise from post-deploy log messages)
Images
But: for long image tags like
php:7.4-fpm-alpine3.13
this could make the display Very Wide. Should we break it onto separate lines for upgrades, rather? Or is it rare enough that this is an OK default?i like how it shows what's changing!
for logs, i always go to tap since it shows ok / not ok and it's easy to read. maybe something like that, with custom prefixes? what abra version had the INFO/WARN/etc prefixes? i'm not sure i've seen them lately, but i've only been deploying upgrades
I think current
main
abra (still?) has those prefixes for abra's own logs:For Docker logs (to display after "INFO initialising deployment", I'm not aware of the Docker daemon giving us log-level info; if there is a way of getting it then 💯 it would be great to add those same prefix badges.
Anyway, two ❤️ on the proposed UI I will aim to implement it this week.
@3wordchant check out
pkg/ui/deploy.go
for the gory details! we're receiving all messages from the runtime and decoding and choosing / throwing away some to show on theabra
side. i've tried to make more sense of that but it's pretty chaotic... throw in a debug statement somewhere and you'll get a taste for it! Loving the UI developments here 🙏