rm doesn't clean up config
#577
No Assignees
decentral1se
decentral1se
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: toolshed/abra#577
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I've created an app using
abra app new ..then removed it usingabra app rm ...butdocker config lson the server shows the configs from this app are not cleaned upOne thing that could be the reason, the recipe had a config during the creation that wasn't there during the cleanup, perhaps some sort of an error silently happened during the rm process
I believe the compose configs are merged to discover configs/secrets/etc. and then things are deleted. So, if you change your config, yes, you can disrupt what will be deleted. We could implement a more thorough cleanup searching for configs/secrets/volumes/etc. matching the convention? I'm not sure if this would have unintended consequences.
Hmmm maybe we just list the names of resources that could need cleanup but we are unsure so users should decide and manually clean them up if desire? that would be a good compromise but also i don't feel like it's a high priority or urgent issue
OK I looked a bit deeper into it. The situation is that we do actually filter on the remote swarm using a strict set of filters which do an exact match on the app domain. We weren't handling the deletion of app configs at all because
docker stack rmhandles that for us. However, you can get a bunch of these old configs lurking on the system for$reasonswhen hacking. So, good that this was raised! #600 should clean those configs up now.