toolshed/abra
4
4
Fork 22
Code Issues 76 Pull Requests 10 Packages Releases 45 Activity

rm doesn't clean up config #577

New Issue
Closed
opened 2025-06-18 22:29:16 +00:00 by ammaratef45 · 4 comments
ammaratef45 commented 2025-06-18 22:29:16 +00:00
Member
Copy Link
Copy Source

I've created an app using abra app new .. then removed it using abra app rm ... but docker config ls on the server shows the configs from this app are not cleaned up

I've created an app using `abra app new ..` then removed it using `abra app rm ...` but `docker config ls` on the server shows the configs from this app are not cleaned up
ammaratef45 added the bug label 2025-06-18 22:29:16 +00:00
ammaratef45 commented 2025-06-18 22:32:40 +00:00
Author
Member
Copy Link
Copy Source

One thing that could be the reason, the recipe had a config during the creation that wasn't there during the cleanup, perhaps some sort of an error silently happened during the rm process

One thing that could be the reason, the recipe had a config during the creation that wasn't there during the cleanup, perhaps some sort of an error silently happened during the rm process
decentral1se commented 2025-06-22 10:16:08 +00:00
Owner
Copy Link
Copy Source

I believe the compose configs are merged to discover configs/secrets/etc. and then things are deleted. So, if you change your config, yes, you can disrupt what will be deleted. We could implement a more thorough cleanup searching for configs/secrets/volumes/etc. matching the convention? I'm not sure if this would have unintended consequences.

I believe the compose configs are merged to discover configs/secrets/etc. and then things are deleted. So, if you change your config, yes, you can disrupt what will be deleted. We could implement a more thorough cleanup searching for configs/secrets/volumes/etc. matching the convention? I'm not sure if this would have unintended consequences.
👍 2
decentral1se self-assigned this 2025-07-08 09:58:43 +00:00
decentral1se added this to the Abra v0.11.x project 2025-07-08 10:06:51 +00:00
ammaratef45 commented 2025-07-26 23:06:38 +00:00
Author
Member
Copy Link
Copy Source

Hmmm maybe we just list the names of resources that could need cleanup but we are unsure so users should decide and manually clean them up if desire? that would be a good compromise but also i don't feel like it's a high priority or urgent issue

Hmmm maybe we just list the names of resources that could need cleanup but we are unsure so users should decide and manually clean them up if desire? that would be a good compromise but also i don't feel like it's a high priority or urgent issue
👍 1
decentral1se commented 2025-08-17 13:16:09 +00:00
Owner
Copy Link
Copy Source

OK I looked a bit deeper into it. The situation is that we do actually filter on the remote swarm using a strict set of filters which do an exact match on the app domain. We weren't handling the deletion of app configs at all because docker stack rm handles that for us. However, you can get a bunch of these old configs lurking on the system for $reasons when hacking. So, good that this was raised! #600 should clean those configs up now.

OK I looked a bit deeper into it. The situation is that we do actually filter on the remote swarm using a strict set of filters which do an exact match on the app domain. We weren't handling the deletion of app configs at all because `docker stack rm` handles that for us. However, you can get a bunch of these old configs lurking on the system for `$reasons` when hacking. So, good that this was raised! https://git.coopcloud.tech/toolshed/abra/pulls/600 should clean those configs up now.
❤️ 2
decentral1se moved this to Done in Abra v0.11.x on 2025-08-17 13:28:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 build
go build related issues
 ci/cd
Building things with CI/CD
 critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
 design
UI/UX
 documentation
Documenting all the things
 duplicate
This issue or pull request already exists
 easy-first-issue
Something for new people to get stuck into. We hope it's easy!
 enhancement
New feature
 help wanted
Need some help
 i10n
Everything to do with localisation
 i18n
Everything to do with internationalisation
 installer
Everything to do with the install script.
 invalid
Something is wrong
 question
More information is needed
 release
Release management
 release-candidate
Related to the new release candidate
 security
Security related
 tech-debt
test
Unit/integration testing
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project Abra v0.11.x
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm BornDeleuze Brooke carla cas (Cassowary) coopcloud cyrnel decentral1se (decentral1se) dede fauno (fauno) iexos jade (Jade Ambrose) jjsfunhouse jmakdah2 joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie moosemower moritz notplants oxaliq (sorrel) p4u1 pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) renovate-bot (Comrade Renovate Bot) ripclap simon sixsmith (Sixsmith) stevensting trav val (val (he/him)) yksflip
No Assignees decentral1se
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?