feat: auto-release abra with goreleaser when a tag is pushed #73

knoflook · 2021-09-06T13:49:30Z

knoflook commented

2021-09-06 13:49:30 +00:00

Closes #71

This might change what Drone does when a commit is pushed, because it's now monitoring all branches. So maybe you can decide if it's okay. Most development happens on main so I thought it's not a big deal. Now, if you want to make a release, commit and push your changes and then run:
git tag [version i.e. v0.0.0]
git push origin [version]
and it should automatically build and release.

Closes #71 This might change what Drone does when a commit is pushed, because it's now monitoring all branches. So maybe you can decide if it's okay. Most development happens on main so I thought it's not a big deal. Now, if you want to make a release, commit and push your changes and then run: `git tag [version i.e. v0.0.0]` `git push origin [version]` and it should automatically build and release.

knoflook added the

enhancement

build

labels 2021-09-06 13:49:33 +00:00

decentral1se requested changes 2021-09-06 14:37:48 +00:00

Dismissed

decentral1se left a comment

💯

.drone.yml Outdated

						
				@ -48,0 +48,4 @@

				    commands:

				      - git fetch --tags

				    depends_on:

				      - notify on failure

decentral1se commented

2021-09-06 14:35:59 +00:00

When a successful build runs, the notify on failure doesn't run because there was no failure.

So, fetch and release will be skipped then. I think you need to do:

depends_on:
- make check
- make build
- make test

You're also missing this?

when:
  event: tag

When a successful build runs, the `notify on failure` doesn't run because there was no failure. So, `fetch` and `release` will be skipped then. I think you need to do: ```yaml depends_on: - make check - make build - make test ``` You're also missing this? ```yaml when: event: tag ```

decentral1se marked this conversation as resolved

.drone.yml Outdated

						
				@ -48,0 +51,4 @@

				      - notify on failure

				  - name: release

				    image: golang

decentral1se commented

2021-09-06 14:36:48 +00:00

Can we pin to 1.16 to use the same as development? Using just golang here means latest which might give us inconsistencies somewhere down the line.

Can we pin to `1.16` to use the same as development? Using just `golang` here means `latest` which might give us inconsistencies somewhere down the line.

👍 1

decentral1se marked this conversation as resolved

go.sum Outdated

						
				@ -37,8 +37,6 @@ cloud.google.com/go/storage v1.5.0/go.mod h1:tpKbwo567HUNpVclU5sGELwQWBDZ8gh0Zeo

				cloud.google.com/go/storage v1.6.0/go.mod h1:N7U0C8pVQ/+NIKOBQyamJIeKQKkZ+mxpohlUTyfDhBk=

				cloud.google.com/go/storage v1.8.0/go.mod h1:Wv1Oy7z6Yz3DshWRJFhqM/UCfaWIRTdp0RXyy7KQOVs=

				cloud.google.com/go/storage v1.10.0/go.mod h1:FLPqc6j+Ki4BU591ie1oL6qBQGu2Bl/tZ9ullr3+Kg0=

				coopcloud.tech/tagcmp v0.0.0-20210825131340-4ef558bb7ada h1:MUjktvV/Oc/VCNzJuxMfm+0t9gKfbRrSLoA8sprtZ6U=