toolshed/abra
3
3
Fork 21
Code Issues 53 Pull Requests 1 Packages Releases 45 Activity

recipe release testing cleanup insufficient #768

New Issue
Open
opened 2026-02-13 15:42:25 +00:00 by iexos · 1 comment
iexos commented 2026-02-13 15:42:25 +00:00
Member
Copy Link

While working on a recipe release test I noticed that the test recipe was initially on a detached head if running the test isolated but on main branch if running the whole file, making the test fail in one case and succeed in the other. needless to say, this should not happen as it adds confusion

While working [on a recipe release test](https://git.coopcloud.tech/toolshed/abra/src/commit/23268a0e9251df9db89f6fc31979fb5c7b8c74bd/tests/integration/recipe_release.bats#L116) I noticed that the test recipe was initially on a detached head if running the test isolated but on main branch if running the whole file, making the test fail in one case and succeed in the other. needless to say, this should not happen as it adds confusion
👍 1
iexos added the
test
 label 2026-02-13 15:42:25 +00:00
decentral1se changed title from recipe testing cleanup insufficient to test: `recipe release` testing cleanup insufficient 2026-02-13 15:57:44 +00:00
decentral1se changed title from test: `recipe release` testing cleanup insufficient to `recipe release` testing cleanup insufficient 2026-02-13 15:57:53 +00:00
decentral1se commented 2026-02-15 13:18:48 +00:00
Owner
Copy Link

@iexos

Yes, I have struggled with this. In general, a simple solution is to use the per-file global teardown() function to ensure that things get cleaned up. The nuclear approach is usually to go with:

tests/integration/helpers/recipe.bash Lines 17 to 23 in 2c5a273fa7
_reset_recipe(){
run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE"
assert_success
assert_not_exists "$ABRA_DIR/recipes/$TEST_RECIPE"
_fetch_recipe
}

There are some other helpers in there, you'll know which one fits your situation best.

@iexos Yes, I have struggled with this. In general, a simple solution is to use the per-file global `teardown()` function to ensure that things get cleaned up. The nuclear approach is usually to go with: https://git.coopcloud.tech/toolshed/abra/src/commit/2c5a273fa77fac01eeebdc48b197a8c52ea235d3/tests/integration/helpers/recipe.bash#L17-L23 There are some other helpers in there, you'll know which one fits your situation best.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
tech-debt
test
Unit/integration testing
wontfix
This won't be fixed
No Label
test
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith stevensting trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#768
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?