do not run _ensure_swarm during test setup if using remote server #769

New Issue

2026-02-13T16:33:35Z

iexos commented

2026-02-13 16:33:35 +00:00

right now you always need a working docker setup, regardless of $TEST_SERVER

right now you always need a working docker setup, regardless of `$TEST_SERVER`

👍 1

iexos added the test label 2026-02-13 16:33:35 +00:00

decentral1se commented

2026-02-15 13:14:57 +00:00

@iexos

I believe you could create a helper, e.g. is_local() (or whatever) which does a check if TEST_SERVER=default is true or not and wraps the call to _ensure_swarm around here with it:

abra/tests/integration/helpers/common.bash Line 22 in 2c5a273fa7

_ensure_swarm

@iexos I believe you could create a helper, e.g. `is_local()` (or whatever) which does a check if `TEST_SERVER=default` is true or not and wraps the call to `_ensure_swarm` around here with it: https://git.coopcloud.tech/toolshed/abra/src/commit/2c5a273fa77fac01eeebdc48b197a8c52ea235d3/tests/integration/helpers/common.bash#L22

devydave commented

2026-08-06 10:48:07 +00:00

I digged into this a bit and went with the is_local function to ensure docker swarm is available on the client and server. Also it is not possible to remove the dependency of a local docker setup because --local always runs on the client that runs abra.
Maybe it can be possible when the behaviour of the "create local server fails when no docker swarm" test changes and it needs more validation on the app_cmd tests, wheather it is really needed.

I digged into this a bit and went with the is_local function to ensure docker swarm is available on the client and server. Also it is not possible to remove the dependency of a local docker setup because --local always runs on the client that runs abra. Maybe it can be possible when the behaviour of the "create local server fails when no docker swarm" test changes and it needs more validation on the _app_cmd_ tests, wheather it is really needed.

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#769

do not run _ensure_swarm during test setup if using remote server #769

do not run `_ensure_swarm` during test setup if using remote server #769