toolshed/abra
4
4
Fork 23
Code Issues 82 Pull Requests 13 Packages Releases 45 Activity

feat: auto-complete app and recipe names #89

Merged
decentral1se merged 3 commits from knoflook/abra:main into main 2021-09-08 12:16:42 +00:00
Conversation 1 Commits 3 Files Changed 16
+205 -1
knoflook commented 2021-09-07 15:01:33 +00:00
Owner
Copy Link
Copy Source

@decentral1se in #83

Added bonus request: seems like we can BashComplete: func(c *cli.Context) { ... }? for abra app $tab/abra recipe $tab?

here it is. I only set it for a couple commands and still would like to discuss #87 but yeah, app/recipe name autocompletion is there!

@decentral1se in #83 >Added bonus request: seems like we can BashComplete: func(c *cli.Context) { ... }? for abra app $tab/abra recipe $tab? here it is. I only set it for a couple commands and still would like to discuss #87 but yeah, app/recipe name autocompletion is there!
knoflook added 1 commit 2021-09-07 15:01:38 +00:00
feat: auto-complete app and recipe names
continuous-integration/drone/pr Build is passing
Details
4c216fdf40
decentral1se reviewed 2021-09-07 17:11:35 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Wowza 🥇

Wowza 🥇
cli/app/undeploy.go Outdated
@@ -36,2 +38,4 @@
return nil
},
BashComplete: func(c *cli.Context) {
appNames, err := config.GetDeployedApps()
decentral1se commented 2021-09-07 17:06:18 +00:00
Owner
Copy Link
Copy Source

Given coop-cloud/abra#87 (comment) I guess we can just do config.GetAppsNames and call it a day?

Given https://git.coopcloud.tech/coop-cloud/abra/issues/87#issuecomment-8528 I guess we can just do `config.GetAppsNames` and call it a day?
knoflook marked this conversation as resolved
pkg/config/app.go Outdated
@@ -177,6 +177,46 @@ func GetApps(appFiles AppFiles) ([]App, error) {
return apps, nil
}
func GetAppsNames() ([]string, error) {
decentral1se commented 2021-09-07 17:08:51 +00:00
Owner
Copy Link
Copy Source

Maybe a nitpick but GetAppNames is easier to say 😀 (ignore ofc if you don't mind it)

Maybe a nitpick but `GetAppNames` is easier to say 😀 (ignore ofc if you don't mind it)
knoflook marked this conversation as resolved
pkg/config/app.go Outdated
@@ -180,0 +180,4 @@
func GetAppsNames() ([]string, error) {
appFiles, err := LoadAppFiles("")
if err != nil {
return nil, err
decentral1se commented 2021-09-07 17:08:06 +00:00
Owner
Copy Link
Copy Source

return []string{}, err to pass an empty list and avoid nil errors somewhere else?

`return []string{}, err` to pass an empty list and avoid nil errors somewhere else?
knoflook marked this conversation as resolved
pkg/config/app.go Outdated
@@ -180,0 +195,4 @@
return appNames, nil
}
func GetDeployedApps() ([]string, error) {
decentral1se commented 2021-09-07 17:11:21 +00:00
Owner
Copy Link
Copy Source

Yeah I guess we don't need this now but maybe keep it?

idk, could also just end up lurking there without being used 🤔

Yeah I guess we don't need this now but maybe keep it? idk, could also just end up lurking there without being used 🤔
knoflook commented 2021-09-08 11:40:59 +00:00
Author
Owner
Copy Link
Copy Source

It's simple enought to rewrite so might as well get rid of it

It's simple enought to rewrite so might as well get rid of it
knoflook marked this conversation as resolved
knoflook added 1 commit 2021-09-08 11:45:48 +00:00
refactor: drop unused function, rename GetAppsNames
continuous-integration/drone/pr Build is passing
Details
cf2653fef8
knoflook added 1 commit 2021-09-08 12:01:45 +00:00
feat: autocomplete recipe names for more abra commands
continuous-integration/drone/pr Build is passing
Details
511619722f
decentral1se merged commit e114b2a939 into main 2021-09-08 12:16:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
 build
go build related issues
 ci/cd
Building things with CI/CD
 critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
 design
UI/UX
 documentation
Documenting all the things
 duplicate
This issue or pull request already exists
 easy-first-issue
Something for new people to get stuck into. We hope it's easy!
 enhancement
New feature
 help wanted
Need some help
 i10n
Everything to do with localisation
 i18n
Everything to do with internationalisation
 installer
Everything to do with the install script.
 invalid
Something is wrong
 question
More information is needed
 release
Release management
 release-candidate
Related to the new release candidate
 security
Security related
 tech-debt
test
Unit/integration testing
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm BornDeleuze Brooke carla cas (Cassowary) coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) iexos jade (Jade Ambrose) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) moosemower moritz notplants oxaliq (sorrel) p4u1 pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) renovate-bot (Comrade Renovate Bot) ripclap simon sixsmith (Sixsmith) stevensting trav (Trav Fryer) val (val (he/him)) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#89