toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: make branches available as recipe source #453

Closed
stevensting wants to merge 3 commits from branch-recipes into main
pull from: branch-recipes
merge into: toolshed:main
Conversation 7 Commits 3 Files Changed 3 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 65c9f4c48a - Show all commits

2
pkg/recipe/compose.go
View File

@ -95,7 +95,7 @@ func (r Recipe) GetVersionLabelLocal() (string, error) {
for _, service := range config.Services {
for label, value := range service.Deploy.Labels {
log.Debugf("checking deploy label '%s'", label)
log.Debugf("checking deploy label '%s' with value '%s' for correct formatting", label, value)
decentral1se marked this conversation as resolved Outdated
decentral1se commented 2024-12-26 18:49:15 +00:00
Outdated
Review
Copy Link

Could we make this message more specific, e.g. what are we checking for?

Also, you don't log the value, is that by choice?

Could we make this message more specific, e.g. what are we checking for? Also, you don't log the `value`, is that by choice?
if strings.HasPrefix(label, "coop-cloud") && strings.Contains(label, "version") {
return value, nil
}

2
pkg/recipe/git.go
View File

@ -68,7 +68,7 @@ func (r Recipe) EnsureExists() error {
// EnsureVersion checks whether a specific version exists for a recipe.
func (r Recipe) EnsureVersion(version string) (bool, error) {
isChaosCommit := false
log.Debugf("Ensuring version '%s'", version)
log.Debugf("ensuring version '%s' exists for recipe '%s'", version, r.Name)
decentral1se marked this conversation as resolved Outdated
decentral1se commented 2024-12-26 18:49:48 +00:00
Outdated
Review
Copy Link

%s/Ensuring/ensuring (lowercase convention everywhere else in the codebase).

Also, can you make this more specific, e.g. using the r.Name there too?

`%s/Ensuring/ensuring` (lowercase convention everywhere else in the codebase). Also, can you make this more specific, e.g. using the `r.Name` there too?
if err := gitPkg.EnsureGitRepo(r.Dir); err != nil {
return isChaosCommit, err