From 0bcfa850805d3981fce1a55108572814d1763daa Mon Sep 17 00:00:00 2001 From: Boaz Shuster Date: Wed, 1 Nov 2017 11:29:37 +0200 Subject: [PATCH] Nitpick plugin/manager.go: use loop to create directories Instead of duplicating the same if condition per plugin manager directory, use one if condition and a for-loop. Signed-off-by: Boaz Shuster Upstream-commit: d75f1d848721f04fdc703a2e88a98600f29933a6 Component: engine --- components/engine/plugin/manager.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/components/engine/plugin/manager.go b/components/engine/plugin/manager.go index e0ac6e85fb..f144e8208b 100644 --- a/components/engine/plugin/manager.go +++ b/components/engine/plugin/manager.go @@ -107,14 +107,10 @@ func NewManager(config ManagerConfig) (*Manager, error) { manager := &Manager{ config: config, } - if err := os.MkdirAll(manager.config.Root, 0700); err != nil { - return nil, errors.Wrapf(err, "failed to mkdir %v", manager.config.Root) - } - if err := os.MkdirAll(manager.config.ExecRoot, 0700); err != nil { - return nil, errors.Wrapf(err, "failed to mkdir %v", manager.config.ExecRoot) - } - if err := os.MkdirAll(manager.tmpDir(), 0700); err != nil { - return nil, errors.Wrapf(err, "failed to mkdir %v", manager.tmpDir()) + for _, dirName := range []string{manager.config.Root, manager.config.ExecRoot, manager.tmpDir()} { + if err := os.MkdirAll(dirName, 0700); err != nil { + return nil, errors.Wrapf(err, "failed to mkdir %v", dirName) + } } if err := setupRoot(manager.config.Root); err != nil {