From 0e7b49da2ede169bc4a72c6a5a0289984034f445 Mon Sep 17 00:00:00 2001 From: Dennis Chen Date: Sat, 28 Apr 2018 15:45:23 +0800 Subject: [PATCH] Add `--target` name case sensitive test code for multi-stage build Add testing code to cover the `--target` name case sensitive issue reported by issue #36956. Signed-off-by: Dennis Chen Upstream-commit: a95fabc70efacc1ff6c0c62c490cf551215bc503 Component: engine --- .../engine/integration-cli/docker_cli_build_test.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/components/engine/integration-cli/docker_cli_build_test.go b/components/engine/integration-cli/docker_cli_build_test.go index cd57d591f2..2ed5e44d8f 100644 --- a/components/engine/integration-cli/docker_cli_build_test.go +++ b/components/engine/integration-cli/docker_cli_build_test.go @@ -5965,10 +5965,16 @@ func (s *DockerSuite) TestBuildIntermediateTarget(c *check.C) { cli.BuildCmd(c, "build1", build.WithExternalBuildContext(ctx), cli.WithFlags("--target", "build-env")) - //res := inspectFieldJSON(c, "build1", "Config.Cmd") res := cli.InspectCmd(c, "build1", cli.Format("json .Config.Cmd")).Combined() c.Assert(strings.TrimSpace(res), checker.Equals, `["/dev"]`) + // Stage name is case-insensitive by design + cli.BuildCmd(c, "build1", build.WithExternalBuildContext(ctx), + cli.WithFlags("--target", "BUIld-EnV")) + + res = cli.InspectCmd(c, "build1", cli.Format("json .Config.Cmd")).Combined() + c.Assert(strings.TrimSpace(res), checker.Equals, `["/dev"]`) + result := cli.Docker(cli.Build("build1"), build.WithExternalBuildContext(ctx), cli.WithFlags("--target", "nosuchtarget")) result.Assert(c, icmd.Expected{