toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix flaky unit test

Browse Source 
Fix flaky test `TestHTTPTimeout` caused by precision problem.

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
Upstream-commit: bc5768733db79874d8918e8499df01d68cae2d6e
Component: engine
This commit is contained in:
Zhang Wei
2016-09-17 19:40:58 +08:00
parent 32dd641688
commit 1dc2c82ca8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/engine/pkg/plugins/client_test.go
View File

@ -47,14 +47,14 @@ func testHTTPTimeout(t *testing.T, timeout, epsilon time.Duration) {
t.Fatalf("The request should be canceled %v", err)
}
elapsed := time.Now().Sub(begin)
if elapsed < timeout || elapsed > timeout+epsilon {
if elapsed < timeout-epsilon || elapsed > timeout+epsilon {
t.Fatalf("elapsed time: got %v, expected %v (epsilon=%v)",
elapsed, timeout, epsilon)
}
}
func TestHTTPTimeout(t *testing.T) {
testHTTPTimeout(t, 5*time.Second, 1*time.Second)
testHTTPTimeout(t, 5*time.Second, 500*time.Millisecond)
}
func TestFailedConnection(t *testing.T) {