From 3b33d2d58031307a9069acc358eac112d9ae74d5 Mon Sep 17 00:00:00 2001 From: Tom Booth Date: Wed, 26 Oct 2016 14:14:15 +0100 Subject: [PATCH] Do not directly cast io.ReadSeeker to io.Reader `golint` had the following issue when linting this file: ``` daemon/logger/jsonfilelog/read.go:116:10: should omit type io.Reader from declaration of var rdr; it will be inferred from the right-hand side ``` In order to keep it happy changing it to an indirect assignment will still maintain the same functionality. Signed-off-by: Tom Booth Upstream-commit: 6314bec641b473571c0160d85bdc70250342185a Component: engine --- components/engine/daemon/logger/jsonfilelog/read.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/components/engine/daemon/logger/jsonfilelog/read.go b/components/engine/daemon/logger/jsonfilelog/read.go index 4401fec013..0ac0cb35ff 100644 --- a/components/engine/daemon/logger/jsonfilelog/read.go +++ b/components/engine/daemon/logger/jsonfilelog/read.go @@ -113,7 +113,8 @@ func (l *JSONFileLogger) readLogs(logWatcher *logger.LogWatcher, config logger.R } func tailFile(f io.ReadSeeker, logWatcher *logger.LogWatcher, tail int, since time.Time) { - var rdr io.Reader = f + var rdr io.Reader + rdr = f if tail > 0 { ls, err := tailfile.TailFile(f, tail) if err != nil {