From 73ef4f0ecfce6881b5430bcc3cacbfe9fb6c1f4c Mon Sep 17 00:00:00 2001 From: Ahmet Alp Balkan Date: Thu, 9 Apr 2015 04:01:39 -0700 Subject: [PATCH] cli_info_test: Check all required fields `TestInfoEnsureSucceeds` is supposed to check existence of all expected fields that are going to be shown in `docker info` command. If this list was complete, it could have helped catching the missing `"Logging Driver:"` regression. Signed-off-by: Ahmet Alp Balkan Upstream-commit: 4c69d0dd8ade90b6602147b8dfb8c1f4c267d3bc Component: engine --- .../engine/integration-cli/docker_cli_info_test.go | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/components/engine/integration-cli/docker_cli_info_test.go b/components/engine/integration-cli/docker_cli_info_test.go index 68c24f292d..e6b79f01f7 100644 --- a/components/engine/integration-cli/docker_cli_info_test.go +++ b/components/engine/integration-cli/docker_cli_info_test.go @@ -14,7 +14,18 @@ func TestInfoEnsureSucceeds(t *testing.T) { t.Fatalf("failed to execute docker info: %s, %v", out, err) } - stringsToCheck := []string{"Containers:", "Execution Driver:", "Logging Driver:", "Kernel Version:"} + // always shown fields + stringsToCheck := []string{ + "ID:", + "Containers:", + "Images:", + "Execution Driver:", + "Logging Driver:", + "Operating System:", + "CPUs:", + "Total Memory:", + "Kernel Version:", + "Storage Driver:"} for _, linePrefix := range stringsToCheck { if !strings.Contains(out, linePrefix) {