From 7d9ea25564e8f4b83c393577841930c8ba6f19cf Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 5 Nov 2024 10:01:18 +0100 Subject: [PATCH] templates: remove redundant capturing of loop vars in tests (copyloopvar) go1.22 and up now produce a unique variable in loops, tehrefore no longer requiring to capture the variable manually; service/logs/parse_logs_test.go:50:3: The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar) tc := tc ^ Signed-off-by: Sebastiaan van Stijn --- templates/templates_test.go | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/templates/templates_test.go b/templates/templates_test.go index 74f1a3b3d1..608fe72a20 100644 --- a/templates/templates_test.go +++ b/templates/templates_test.go @@ -64,25 +64,23 @@ func TestParseTruncateFunction(t *testing.T) { }, } - for _, testCase := range testCases { - testCase := testCase - - tm, err := Parse(testCase.template) + for _, tc := range testCases { + tm, err := Parse(tc.template) assert.NilError(t, err) - t.Run("Non Empty Source Test with template: "+testCase.template, func(t *testing.T) { + t.Run("Non Empty Source Test with template: "+tc.template, func(t *testing.T) { var b bytes.Buffer assert.NilError(t, tm.Execute(&b, source)) - assert.Check(t, is.Equal(testCase.expected, b.String())) + assert.Check(t, is.Equal(tc.expected, b.String())) }) - t.Run("Empty Source Test with template: "+testCase.template, func(t *testing.T) { + t.Run("Empty Source Test with template: "+tc.template, func(t *testing.T) { var c bytes.Buffer assert.NilError(t, tm.Execute(&c, "")) assert.Check(t, is.Equal("", c.String())) }) - t.Run("Nil Source Test with template: "+testCase.template, func(t *testing.T) { + t.Run("Nil Source Test with template: "+tc.template, func(t *testing.T) { var c bytes.Buffer assert.Check(t, tm.Execute(&c, nil) != nil) assert.Check(t, is.Equal("", c.String()))