From 60759a8d1a77405141dd6da22eb0bba66a3991cf Mon Sep 17 00:00:00 2001 From: Solomon Hykes Date: Mon, 23 Dec 2013 23:07:01 +0000 Subject: [PATCH 1/2] Move utility package 'systemd' to pkg/systemd Upstream-commit: 8e7db0432e21adb3a753188d5321ce1165fa8964 Component: engine --- components/engine/api.go | 2 +- components/engine/{ => pkg}/systemd/sd_notify.go | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename components/engine/{ => pkg}/systemd/sd_notify.go (100%) diff --git a/components/engine/api.go b/components/engine/api.go index da1fa9edee..1128c7a2b7 100644 --- a/components/engine/api.go +++ b/components/engine/api.go @@ -10,7 +10,7 @@ import ( "fmt" "github.com/dotcloud/docker/archive" "github.com/dotcloud/docker/auth" - "github.com/dotcloud/docker/systemd" + "github.com/dotcloud/docker/pkg/systemd" "github.com/dotcloud/docker/utils" "github.com/gorilla/mux" "io" diff --git a/components/engine/systemd/sd_notify.go b/components/engine/pkg/systemd/sd_notify.go similarity index 100% rename from components/engine/systemd/sd_notify.go rename to components/engine/pkg/systemd/sd_notify.go From 3df2c5ea875cdfdb9ac0bf95583025113d380b65 Mon Sep 17 00:00:00 2001 From: Solomon Hykes Date: Mon, 23 Dec 2013 23:12:19 +0000 Subject: [PATCH 2/2] Add README to pkg Upstream-commit: 652c2c2a80cd119ffb8017c25e741ddad9399236 Component: engine --- components/engine/pkg/README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 components/engine/pkg/README.md diff --git a/components/engine/pkg/README.md b/components/engine/pkg/README.md new file mode 100644 index 0000000000..c4b78a8ad8 --- /dev/null +++ b/components/engine/pkg/README.md @@ -0,0 +1,11 @@ +pkg/ is a collection of utility packages used by the Docker project without being specific to its internals. + +Utility packages are kept separate from the docker core codebase to keep it as small and concise as possible. +If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the +Docker organization, to facilitate re-use by other projects. However that is not the priority. + +The directory `pkg` is named after the same directory in the camlistore project. Since Brad is a core +Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad! + +Because utility packages are small and neatly separated from the rest of the codebase, they are a good +place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!